Docs for emissive color on StandardMaterial #20497
Merged
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Docs
alice-i-cecile
added
S-Needs-Review
atlv24
approved these changes
Aug 10, 2025
crates/bevy_pbr/src/pbr_material.rs
Outdated
| /// From a physical perspective, the units of the emissive color | ||
| /// are given in luminance (cd/m², aka nits), which is a measure of | ||
| /// the amount of light emitted per unit area. | ||
| /// | ||
| /// Increasing the emissive strength of the color will impact visual effects | ||
| /// like bloom, but it's important to note that **an emissive material won't | ||
| /// light up surrounding areas like a light source**, |
There was a problem hiding this comment.
an emissive material won't light up surrounding areas like a light source
Unless you're using solari :P
atlv24
approved these changes
Aug 11, 2025
JMS55
reviewed
Aug 11, 2025
tychedelia
approved these changes
Aug 12, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
|
Did #13350 get reverted? Because that PR changed the emissive value so that it is not in units of cd/m^2 but rather is relative to the camera exposure. The problem is the gltf spec gives two completely contradictory answers for what units the value is in, but no way to tell which is used. Both are reasonable in different situations, but materials using one convention will look totally wrong when rendered assuming the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #18993.
Solution
I've done my best to synthesize and carefully word the discussion in the linked issue. That said, this is not my domain, so critique is very welcome.