Error on unloaded ImageRenderTarget #20503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecoskey
added
C-Bug
ecoskey
force-pushed
the
fix/image_target
branch
from
76654cd to
409b13d
Compare
alice-i-cecile
added
S-Waiting-on-Author
tychedelia
approved these changes
Aug 11, 2025
ecoskey
added
S-Needs-Review
alice-i-cecile
requested changes
Aug 12, 2025
alice-i-cecile
added
M-Needs-Migration-Guide
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
ecoskey
added
S-Needs-Review
ecoskey
force-pushed
the
fix/image_target
branch
from
36668da to
5ac3c6a
Compare
alice-i-cecile
approved these changes
Aug 14, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
When using
RenderTarget::Imagewith an image set to use in the render world only, thecamera_systemis unable to get its render target info and fails silently, breaking things down the line. From what I saw the view uniforms stopped updating, but there might be other things it broke as well.Solution
At least make it fail loudly :)
Not sure if it should panic here, or return a better error enum that the caller can decide what to do with. Should all failures to update the render target info be hard errors?
Testing
Error gets printed when running the project I found the bug with