impl From<f32> and From<i32> for Val

[ickshonpe]

Objective

impl From<f32> and From<i32> for Val

Solution

impl From<f32> and From<i32> for Val

[alice-i-cecile]

Related to #15937.

[TheBlckbird]

I don't think, this is a good idea for the reasons mentioned in #15937 (comment)

And besides, if we have helper functions, four characters more for writing px(10) doesn't really make the difference. It only makes the code more readable and sticks more to the Rust idiom of not doing implicit stuff.

And besides (I already mentioned this in the issue), how should users know, that this is pixels? We still don't have a good place for documentation and just assuming, everyone knows, that a unitless value will be in pixels, will lead to confusion.

Picture yourself, not knowing anything about Bevy and you're reading code where a width of 100 is specified. You will need to google this or just assume it's going to be in pixels without being sure.
Now the other option would to call the helper function, which will immediately tell you the unit and therefore resolve any confusion.

So I'm definitely for closing this and adding the trait someone proposed to the other PR (#20518 (comment)).

[ickshonpe]

I don't think, this is a good idea for the reasons mentioned in #15937 (comment)

And besides, if we have helper functions, four characters more for writing px(10) doesn't really make the difference. It only makes the code more readable and sticks more to the Rust idiom of not doing implicit stuff.

And besides (I already mentioned this in the issue), how should users know, that this is pixels? We still don't have a good place for documentation and just assuming, everyone knows, that a unitless value will be in pixels, will lead to confusion.

Picture yourself, not knowing anything about Bevy and you're reading code where a width of 100 is specified. You will need to google this or just assume it's going to be in pixels without being sure. Now the other option would to call the helper function, which will immediately tell you the unit and therefore resolve any confusion.

So I'm definitely for closing this and adding the trait someone proposed to the other PR (#20518 (comment)).

IIRC the problem with the AsValNum trait is it wouldn't work with bsn!.

I don't see From<f32> mapping to Val::Px as confusing at all. To me its very natural, CSS and most other layout styling languages do the same thing.

[TheBlckbird]

To me its very natural, CSS and most other layout styling languages do the same thing.

No, you can't have unitless values in CSS (except for 0), you always have to specify it

[ickshonpe]

Oh yeah you're right, it's been years since I've done any css. Most other layout models like figma allow you to ellide the units though.

[cart]

I don't think making px the default implicit unit is the right path. I'd rather be explicit about this, and make this easier using Px(1.) flattened exports.