Skip to content

Split up ComputedUiTargetCamera #20535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 15, 2025
Merged

Split up ComputedUiTargetCamera #20535

merged 16 commits into from
Aug 15, 2025

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Aug 12, 2025 •
edited
Loading

Objective

Remove the render target info from ComputedUiTargetCamera so it just holds the camera id that is only needed for rendering and picking.

Fixes #20534

Solution

  • Remove the render target info from ComputedUiTargetCamera.
  • Create a new component ComputedUiRenderTargetInfo and move the render target info (physical size and scale factor) into it.
  • Update the systems to use the ComputedUiRenderTargetInfo as needed.

Testing

The behaviour of the UI examples should be unchanged.

@ickshonpe ickshonpe changed the title Split ComputedUiTargetCamera Split up ComputedUiTargetCamera Aug 12, 2025
@ickshonpe ickshonpe added A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 12, 2025
@ickshonpe ickshonpe added the A-Camera User-facing camera APIs and controllers. label Aug 12, 2025
@alice-i-cecile alice-i-cecile added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Aug 12, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 14, 2025
@alice-i-cecile
Copy link
Member

@ickshonpe merge conflict time.

@ickshonpe
Copy link
Contributor Author

@alice-i-cecile should be ready now

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 15, 2025
@alice-i-cecile alice-i-cecile mentioned this pull request Aug 15, 2025
Closed
Merged via the queue into bevyengine:main with commit 803a843 Aug 15, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@mogambro mogambro mogambro approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-Camera User-facing camera APIs and controllers. A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split up ComputedUiTargetCamera.
3 participants
@ickshonpe @alice-i-cecile @mogambro