Skip to content

Configure ureq to use platform-verifier for web assets#20825

Merged
mockersf merged 1 commit intobevyengine:mainfrom
jf908:platform-verifier
Oct 25, 2025
Merged

Configure ureq to use platform-verifier for web assets#20825
mockersf merged 1 commit intobevyengine:mainfrom
jf908:platform-verifier

Conversation

@jf908
Copy link
Contributor

@jf908 jf908 commented Sep 2, 2025

Objective

Solution

  • Use ureq's platform-verifier feature and enable it in the agent config.

I've gone the simple route and made this non-configurable, for now at least.

The downside of this change is that you can longer use webpki-roots but if bevy only supports one certificate verification method then I think platform-verifier is the more sensible option.

Testing

  • Tested the web_asset example on Windows and macOS

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Assets Load files from disk to use for things like images, models, and sounds S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 2, 2025
Copy link
Contributor

@andriyDev andriyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work on WASM? Happy to approve if that's the case!

@jf908
Copy link
Contributor Author

jf908 commented Oct 23, 2025

Does this work on WASM? Happy to approve if that's the case!

The changes I have made are all feature flagged behind not wasm 🙂

Copy link
Contributor

@andriyDev andriyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh that would definitely do it then LMAO

@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 23, 2025
@andriyDev andriyDev added this to the 0.18 milestone Oct 23, 2025
@mockersf mockersf added this pull request to the merge queue Oct 25, 2025
Merged via the queue into bevyengine:main with commit d81266a Oct 25, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web assets should default to using the OS's TLS certificates

5 participants