Skip to content

update bevy_ecs MSRV to 1.89.0 #21500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

update bevy_ecs MSRV to 1.89.0 #21500

wants to merge 3 commits into from

Conversation

Victoronz
Copy link
Contributor

@Victoronz Victoronz commented Oct 10, 2025 •
edited
Loading

Objective

Update bevy_ecs MSRV to 1.89 to allow some functions to be turned const in #21498.

Solution

Update the MSRV.

Also fix the clippy lint concerning if && if let chaining that comes with the upgrade.

@Victoronz Victoronz requested a review from mockersf October 10, 2025 21:45
@Victoronz
Copy link
Contributor Author

Is this targeted, minimal upgrade more appropriate?

alice-i-cecile
alice-i-cecile approved these changes Oct 10, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to bump this here. Our policy is "latest stable", and I like splitting this out.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Your PR increases Bevy Minimum Supported Rust Version. Please update the rust-version field in the root Cargo.toml file.

@Victoronz Victoronz mentioned this pull request Oct 10, 2025
Open
@mockersf
Copy link
Member

Not unblocking the linked PR, which needs rust 1.91 which is not yet released.

Bumping MSRV should be done in the PR that needs it, not on its own

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf Awaiting requested review from mockersf

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Victoronz @mockersf @alice-i-cecile