Skip to content

Conversation

@janhohenheim
Copy link
Member

@janhohenheim janhohenheim commented Nov 16, 2025

Objective

  • Duplicate components panic like this:
Bundle [...] has duplicate components: [DebugName { name: "bevy_transform::components::transform::Transform" }]

Solution

  • Let's make them panic like that:
Bundle [...] has duplicate components: ["bevy_transform::components::transform::Transform"]

Testing

  • None, I know the way DebugName is implemented.

@janhohenheim janhohenheim added D-Trivial Nice and easy! A great choice to get started with Bevy C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Diagnostics Logging, crash handling, error reporting and performance analysis S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 16, 2025
@janhohenheim janhohenheim added this to the 0.18 milestone Nov 16, 2025
@janhohenheim janhohenheim added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 16, 2025
@chescock
Copy link
Contributor

Do we ever want that long Debug representation? Instead of just changing it here, it might make sense to manually impl Debug for DebugName in a way that always delegates to Cow<str> as Debug.

@chescock
Copy link
Contributor

Do we ever want that long Debug representation? Instead of just changing it here, it might make sense to manually impl Debug for DebugName in a way that always delegates to Cow<str> as Debug.

I made a PR for this idea: #21870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants