DespawnOnExit / DespawnOnEnter fix log spam #21864
Open
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Nov 16, 2025
alice-i-cecile
added
C-Bug
Member
|
CI has found a couple of spelling errors for you :) |
Typo fixes
Contributor
Author
Fixed! |
mgi388
approved these changes
Nov 17, 2025
Contributor
mgi388
left a comment
mgi388
left a comment
There was a problem hiding this comment.
LGTM. I left suggestions for nits on doc comment formatting for consistency with what is there. Feel free to apply the suggestions yourself, I just did it with the PR reviewer so hopefully I got the suggestions right.
Co-authored-by: mgi388 <[email protected]>
Contributor
Author
Thank you changes applied. |
mgi388
approved these changes
Nov 17, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
janhohenheim
approved these changes
Nov 20, 2025
Member
janhohenheim
left a comment
janhohenheim
left a comment
There was a problem hiding this comment.
Oh yes, I've run into this plenty of times. Thanks!
janhohenheim
added
the
C-Refinement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if entity was despawned such as in a hierachy
Objective
Most if not all use cases don't care if the item is already despawned.
The user is typically saying "Ensure it is despawned" rather then "You should be the one to despawn"
DespawnOnExit/DespawnOnEntercauses log spam when despawning hierarchies #21832Solution
Testing