Skip to content

Fix shader compilation fail when using visibility range #21879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+5 −2
Open

Fix shader compilation fail when using visibility range #21879

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d730a6
fix shader compile fail when using visibility range
newDINO Nov 18, 2025
5dcc4be
fix: imports
NicoZweifel Nov 18, 2025
b79dde8
chore: move import down
NicoZweifel Nov 18, 2025
cd3f1a3
Merge pull request #1 from NicoZweifel/pbr_fix-suggestions
newDINO Nov 18, 2025
481f3c3
removing empty lines
newDINO Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/bevy_pbr/src/render/pbr.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
decal::clustered::apply_decal_base_color,
}



#ifdef PREPASS_PIPELINE
#import bevy_pbr::{
prepass_io::{VertexOutput, FragmentOutput},
Expand All @@ -13,12 +15,15 @@
#else
#import bevy_pbr::{
forward_io::{VertexOutput, FragmentOutput},
pbr_functions,
pbr_functions::{apply_pbr_lighting, main_pass_post_lighting_processing},
pbr_types::STANDARD_MATERIAL_FLAGS_UNLIT_BIT,
}
#endif

#ifdef VISIBILITY_RANGE_DITHER
#import bevy_pbr::pbr_functions::visibility_range_dither;
#endif

#ifdef MESHLET_MESH_MATERIAL_PASS
#import bevy_pbr::meshlet_visibility_buffer_resolve::resolve_vertex_output
#endif
Expand Down Expand Up @@ -50,7 +55,7 @@ fn fragment(
// If we're in the crossfade section of a visibility range, conditionally
// discard the fragment according to the visibility pattern.
#ifdef VISIBILITY_RANGE_DITHER
pbr_functions::visibility_range_dither(in.position, in.visibility_range_dither);
visibility_range_dither(in.position, in.visibility_range_dither);
#endif

#ifdef FORWARD_DECAL
Expand Down