-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
One-to-many asset processing #21889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andriyDev
wants to merge
16
commits into
bevyengine:main
Choose a base branch
from
andriyDev:one-to-many
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,393
−130
Open
One-to-many asset processing #21889
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3621295
Create a test to ensure that we actually gate on file transactions.
andriyDev 4ded24c
Implement one-to-many asset processing.
andriyDev 0abe60a
Add a test for one-to-many asset processing.
andriyDev f65170f
Update the "wrong_hash" test to also check that one-to-many asset pro…
andriyDev db67b4b
Update the `gates_asset_path_on_process` test to also include a "mult…
andriyDev c4dbf69
Use let-else for initializing the asset processor.
andriyDev 77a66f8
Delete the meta file of empty folders to make sure we don't keep arou…
andriyDev c6e5a92
Treat any directory with a meta file as an asset path for processed a…
andriyDev 809ecfc
Delete processed assets (or multi-processed-assets) before processing…
andriyDev 7694049
Recursively look for processor asset infos to block on multi-processe…
andriyDev 60fc4bb
Create a migration guide for Process trait changes.
andriyDev 2c4be0f
Create release notes for one-to-many asset processing.
andriyDev 8181a26
Update the asset processing example to show that we can do one-to-man…
andriyDev c50d0f9
Add some checks to verify the behavior of some error cases for invali…
andriyDev 9ccaaf9
Update some doc comment wording and release note wording.
andriyDev c8f2933
Rename write_single and write_multiple to write_full and write_partia…
andriyDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is essentially saying "once an asset is processed into multiple new assets, you can't load the original asset anymore"? Can we state it more like that if so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a much more obvious way to put it! I slightly reworded it, but overall the same.