Fix an error in migration guides #21892
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `asset_path` method was removed, so proposed fix now yields `no method named `asset_path` found for mutable reference `&mut LoadContext<'c>` in the current scope` The actual fix to get the original path is `.path().path()`
janhohenheim
approved these changes
Nov 20, 2025
janhohenheim
added
C-Docs
Member
|
good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This is a follow up to https://github.com/bevyengine/bevy/pull/21713/files
I noticed something weird in the migration guide --- the
asset_pathmethod was removed,so proposed fix now yields
The actual change to get the original path is
.path().path()Solution
Updated the migration guide
Testing
I've played around with
load_contextinGltfLoaderand checked the signatures the methods returnFound this thanks to Alice's merge train