Skip to content

Solari: Misc improvements #21953

Merged
james7132 merged 7 commits intobevyengine:mainfrom
JMS55:solari6-misc-improvements3
Dec 7, 2025
Merged

Solari: Misc improvements #21953
james7132 merged 7 commits intobevyengine:mainfrom
JMS55:solari6-misc-improvements3

Conversation

@JMS55
Copy link
Contributor

@JMS55 JMS55 commented Nov 27, 2025 •
edited
Loading

  • Search for a spatial neighbor up to 5 times for ReSTIR instead of just once.
  • Bump RAY_T_MIN to 0.001. Prevents artifacts and doesn't really cause more self intersections.
  • Re-calculate world cache cell_size after jittering the query position to prevent creating extra cells at the wrong LOD for a given position.
  • Prevent the unlikely event of something checksumming to 0, which is reserved for empty cells.

@JMS55 JMS55 requested review from SparkyPotato and atlv24 November 27, 2025 04:48
@JMS55 JMS55 added this to the 0.18 milestone Nov 27, 2025
@JMS55 JMS55 added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Refinement Improves output quality, without fixing a clear bug or adding new functionality. labels Nov 27, 2025
SparkyPotato
SparkyPotato reviewed Nov 27, 2025
View reviewed changes
crates/bevy_solari/src/realtime/restir_gi.wgsl
}

return NeighborInfo(spatial_reservoir, spatial_surface.world_position, spatial_surface.world_normal, spatial_diffuse_brdf);
return NeighborInfo(empty_reservoir(), world_position, world_normal, vec3(0.0));
Copy link
Contributor

@SparkyPotato SparkyPotato Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be a real position/normal?

Copy link
Contributor Author

@JMS55 JMS55 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure tbh. Better safe than sorry I feel.

Copy link
Contributor Author

@JMS55 JMS55 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure tbh. Better safe than sorry I feel.

@JMS55 JMS55 requested a review from SparkyPotato November 27, 2025 15:11
@JMS55 JMS55 marked this pull request as ready for review November 29, 2025 02:39
@JMS55 JMS55 requested a review from IceSentry November 29, 2025 02:39
@JMS55 JMS55 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 3, 2025
@james7132 james7132 added this pull request to the merge queue Dec 7, 2025
Merged via the queue into bevyengine:main with commit e44d659 Dec 7, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james7132 james7132 james7132 approved these changes

@atlv24 atlv24 Awaiting requested review from atlv24

+3 more reviewers

@IceSentry IceSentry IceSentry approved these changes

@dloukadakis dloukadakis dloukadakis approved these changes

@SparkyPotato SparkyPotato SparkyPotato approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Refinement Improves output quality, without fixing a clear bug or adding new functionality. S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Rendering (Old)
Status: Done

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

5 participants

@JMS55 @james7132 @IceSentry @dloukadakis @SparkyPotato