systemstate support commands track location #22353
Merged
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Jan 4, 2026
Contributor
|
What's the code that fails before this change? |
chescock
approved these changes
Jan 8, 2026
Contributor
chescock
left a comment
chescock
left a comment
There was a problem hiding this comment.
This makes sense! It's never going to be useful to report a location from these methods, so marking them as #[track_caller] seems like a good plan.
It might be good to also add #[track_caller] to a few other places where system parameters can be nested, such as StaticSystemParam and #[derive(SystemParam)], but those could always be done as a follow-up!
alice-i-cecile
added
S-Ready-For-Final-Review
cart
pushed a commit
that referenced
this pull request
Jan 9, 2026
# Objective When acquiring Commands within SystemState, it causes incorrect tracking of MaybeLocation in CommandQueue, mistakenly pointing to the FromWorld trait implementation. ## Solution Add track_caller support for the Commands SystemParam. ## Testing I only verified whether tracking is present, but did not perform any tests. Co-authored-by: Mushine Lament <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
When acquiring Commands within SystemState, it causes incorrect tracking of MaybeLocation in CommandQueue, mistakenly pointing to the FromWorld trait implementation.
Solution
Add track_caller support for the Commands SystemParam.
Testing
I only verified whether tracking is present, but did not perform any tests.