fix enum reflection based partial_cmp, disallow compare different variant names. #22595
+16
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix #22586
The problem is in #22452 I used
variant_indexto compare two enum values. Because I want to maintain:a,b: Aand tries calla.reflect_partial_cmp(b), the result should align with the version derived onA.But appearently for dynamic types and also
a: A; b: Bdifferent types, the behaviour is a bit chaotic. (see #22586)Solution
Don't compare by
variant_indexanymore. It's a different tradeoff, but I think it's a more sensible one.Testing
Modified unit tests