Remove redundant after ordering from build_text_interop#23165
Open
ickshonpe wants to merge 1 commit intobevyengine:mainfrom
Open
Remove redundant after ordering from build_text_interop#23165ickshonpe wants to merge 1 commit intobevyengine:mainfrom
after ordering from build_text_interop#23165ickshonpe wants to merge 1 commit intobevyengine:mainfrom
Conversation
…interop`: ``` .after(bevy_text::load_font_assets_into_font_collection) .after(bevy_asset::AssetEventSystems) ``` They are redundant because `text_system` runs in `UiSystems::PostLayout`, which is already ordered after `load_font_assets_into_font_collection` and `AssetEventSystems` through `UiSystems::Content`.
ickshonpe
added
A-Text
ickshonpe
added
D-Trivial
kfc35
approved these changes
Feb 28, 2026
Contributor
kfc35
left a comment
kfc35
left a comment
There was a problem hiding this comment.
Verified for myself that removing this is correct logically
kfc35
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Remove these
afterconstraints ontext_systemfrombuild_text_interop:They are redundant because
text_systemruns inUiSystems::PostLayout, which is already ordered afterload_font_assets_into_font_collectionandAssetEventSystemsthroughUiSystems::Content.Solution
Remove them.