single detect_text_needs_rerender system#23166
Open
ickshonpe wants to merge 7 commits intobevyengine:mainfrom
Open
single detect_text_needs_rerender system#23166ickshonpe wants to merge 7 commits intobevyengine:mainfrom
detect_text_needs_rerender system#23166ickshonpe wants to merge 7 commits intobevyengine:mainfrom
Conversation
…interop`: ``` .after(bevy_text::load_font_assets_into_font_collection) .after(bevy_asset::AssetEventSystems) ``` They are redundant because `text_system` runs in `UiSystems::PostLayout`, which is already ordered after `load_font_assets_into_font_collection` and `AssetEventSystems` through `UiSystems::Content`.
Removed the type parameter from `detect_text_needs_rerender`, which now detects changes for all text hierarchies. It no longer checks for changes to the root text entity (`Text` or `Text2d`) itself, which now needs to be checked by the text systems for those components. `detect_text_render` is now added by `TextPlugin` to the `PostUpdate` schedule. `UiPlugin` and `SpritePlugin` no longer add it but schedule their systems to run after it.
ickshonpe
changed the title
detect_text_needs_rerender system
ickshonpe
added
A-Text
…lection to avoid order ambiguities
ickshonpe
added
C-Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
detect_text_needs_rerendershould only handle change detection forTextSpanentities.Fixes #19437
Solution
detect_text_needs_rerender.detect_text_needs_rerendertoPostUpdateinTextPlugin's builder.detect_text_needs_rerenderfrom theTextandText2dplugin builders.Textfor changes inmeasure_textandText2dfor changes inupdate_text2d_layout.Testing
Text examples and tests still okay.