-
Notifications
You must be signed in to change notification settings - Fork 188
[ENH] BEP036 - Phenotypic Data Guidelines #2123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericearl
wants to merge
56
commits into
bids-standard:master
Choose a base branch
from
surchs:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 37 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
3cedc86
Merge pull request #2 from bids-standard/master
ericearl 11fbb47
Merge pull request #3 from bids-standard/master
ericearl 0ef9fdf
[ENH] Integrate BEP036 - Phenotypic Data Guidelines
surchs 0a640e6
Update phenotype.md and data-summary-files.md
ericearl a19512b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5718888
Update data-summary-files.md and phenotypic-and-assessment-data.md
ericearl 8f54e94
Apply suggestions from code review
ericearl 94cb476
Apply suggestions from code review
ericearl 142c460
Apply suggestions from code review
ericearl 8b78359
Update src/modality-agnostic-files/phenotypic-and-assessment-data.md
ericearl 60f712a
Update mkdocs.yml
ericearl e62b5cc
Update src/modality-agnostic-files/phenotypic-and-assessment-data.md
ericearl ac097aa
Update phenotype.md to have a macro table from schema
ericearl 32fedd0
Update src/schema/rules/tabular_data/modality_agnostic.yaml
ericearl aacda9b
Update modality_agnostic.yaml
ericearl fd5ff2d
Update phenotype.md appendix and modality_agnostic.yaml schema
ericearl dd65b5e
Update modality_agnsotic.yaml
ericearl f4205e8
add missing column objects, use existing acq column definition (#4)
rwblair 0eba71d
Updates for BEP036
ericearl d3631a8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f4939ad
Updates phentoype.md and Guideline 3 in the modality agmpstic section
ericearl abd5c2b
Update modality_agnostic.yaml
ericearl ec2c53d
Update phenotypic-and-assessment_data.md
ericearl 7639001
Merge branch 'master' into master
ericearl 8b38859
Merge branch 'bids-standard:master' into master
ericearl d1141a0
Updates to remove demographics file and add AdditionalValidation field
ericearl 6c6ee8b
Attempting to satisfy the CI and remark
ericearl 9f8afec
Merge branch 'bids-standard:master' into master
ericearl 8fa89bc
Update src/schema/rules/tabular_data/modality_agnostic.yaml
effigies ff86669
Update columns.yaml
ericearl ede68ef
Update modality_agnostic.yaml
ericearl e8ab5dd
Update phenotype.md appendix examples, participants schema, and other…
ericearl 3490e9d
Update modality_agnostic.yaml
ericearl d02e0bf
Update modality_agnostic.yaml
ericearl f8d6333
Update modality_agnostic.yaml
ericearl bd083c0
Update phenotype appendix
ericearl ec2703b
Update phenotype appendix
ericearl 00d8f25
Delete .vscode/settings.json
ericearl 41f0f70
Apply suggestions from code review
ericearl cdfc0d2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6cbb4ee
Update BEP036 files more
ericearl fe3ddab
Update appendices/phenotype.md
ericearl 40f6751
Update src/schema/rules/tabular_data/modality_agnostic.yaml
ericearl 2fd12d7
Update src/schema/objects/columns.yaml
ericearl a0cab8b
Update src/appendices/phenotype.md
ericearl c0bd78a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 97917f0
Update src/modality-agnostic-files/data-summary-files.md
ericearl 80683f6
Merge branch 'master' into master
surchs 76932fe
Move longitudinal age section to point 1
surchs 32f994e
Revise section 5
surchs 3a602ca
fix: Participant ID mismatch check
effigies f8d492e
fix(schema): Resolve a couple issues
effigies 7f1eb09
feat: Expanded validation checks
effigies 5c55eb9
deduplicate
effigies c0951f3
Promote Participants
effigies 69183c7
feat: Make MeasurementToolMetadata recommended for phenotype files
effigies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"githubPullRequests.ignoredPullRequestBranches": [ | ||
"master" | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is added by accident in surchs@0eba71d @ericearl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I will try to get it out of there.