fix: order of additionalProducts in carousel
#2791
Merged
+21
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bd30ed3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
matthewvolk
approved these changes
Dec 19, 2025
Contributor
matthewvolk
left a comment
matthewvolk
left a comment
There was a problem hiding this comment.
Looks good! Makes me wonder if people would ever want to change the order of products returned in the collection... but that's outside the scope of this PR. Thanks for taking care of this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Fixes #2790.
Testing
Before
CleanShot.2025-12-19.at.10.13.42.mp4
After
CleanShot.2025-12-19.at.10.14.33.mp4
Migration
Apply this PR's changes to the
core/lib/makeswift/utils/use-bc-product-to-vibes-product/use-bc-product-to-vibes-product.tsandcore/lib/makeswift/utils/use-products.tsfiles.