Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/heavy-hotels-lie.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@bigcommerce/catalyst-makeswift": patch
---

Fix sort order of `additionalProducts` prop in `ProductsCarousel` Makeswift component.
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ export const BcProductSchema = z.object({

export type BcProductSchema = z.infer<typeof BcProductSchema>;

export type { Product };

export function useBcProductToVibesProduct(): (product: BcProductSchema) => Product {
const format = useFormatter();

Expand Down
20 changes: 14 additions & 6 deletions core/lib/makeswift/utils/use-products.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { z } from 'zod';

import {
BcProductSchema,
Product,
useBcProductToVibesProduct,
} from './use-bc-product-to-vibes-product/use-bc-product-to-vibes-product';

Expand All @@ -23,7 +24,10 @@ interface Props {
additionalProductIds: string[];
}

export function useProducts({ collection, collectionLimit = 20, additionalProductIds }: Props) {
export function useProducts({ collection, collectionLimit = 20, additionalProductIds }: Props): {
products: Product[] | null;
isLoading: boolean;
} {
const bcProductToVibesProduct = useBcProductToVibesProduct();
const locale = useLocale();

Expand All @@ -43,13 +47,17 @@ export function useProducts({ collection, collectionLimit = 20, additionalProduc
additionalProductIds.length ? additionalProductsUrl : null,
fetcher,
);
const additionalProducts = useMemo(
() =>
additionalProductIds
.map((id) => additionalData?.products.find((product) => product.entityId.toString() === id))
.filter((product) => product != null),
[additionalData, additionalProductIds],
);

const combinedProducts = useMemo(
() => [
...(collectionData?.products.slice(0, collectionLimit) ?? []),
...(additionalData?.products ?? []),
],
[collectionData, additionalData, collectionLimit],
() => [...(collectionData?.products.slice(0, collectionLimit) ?? []), ...additionalProducts],
[collectionData, additionalProducts, collectionLimit],
);

const isLoading = isCollectionLoading || isAdditionalLoading;
Expand Down