Update Node Versions and types to fix latest tsc upgrade issues #3455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelWest22
commented
Oct 10, 2025
Collaborator
Author
MichaelWest22
left a comment
MichaelWest22
left a comment
There was a problem hiding this comment.
Need to merge this to unblock pipelines
1cg
pushed a commit
that referenced
this pull request
Oct 14, 2025
* Update Node Versions and types to fix latest tsc upgrade issues * fix playwright only test filtering that has broken from playwright browser updates --------- Co-authored-by: MichaelWest22 <[email protected]> (cherry picked from commit 5629997)
1cg
pushed a commit
that referenced
this pull request
Oct 17, 2025
* fix stale currentPathForHistory issue * Update Node Versions and types to fix latest tsc upgrade issues (#3455) * Update Node Versions and types to fix latest tsc upgrade issues * fix playwright only test filtering that has broken from playwright browser updates --------- Co-authored-by: MichaelWest22 <[email protected]> * fix stale currentPathForHistory issue --------- Co-authored-by: MichaelWest22 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typescript locked version got accidently updated to 5.9.2 which causes problems with node internal buffer types because of recent generics handling somehow. This throws errors in tsc type checking preventing blocking all github pipelines running. Instead of just rolling back typescript and leaving this as a problem for our future selves i've updated to the latest tsc version and updated the very old @types/node that was stuck on an old backwards compatible version before. To allow us to update types without issues I had to add --moduleResolution node to the tsc run to support the modern way types are handled. This should prevent future problems with tsc not working as things change.
Corresponding issue:
Testing
Ran tests and types-check to make sure it runs ok after the upgrades
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded