Skip to content

Update Node Versions and types to fix latest tsc upgrade issues #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1cg merged 2 commits into from
Oct 14, 2025
Merged

Update Node Versions and types to fix latest tsc upgrade issues #3455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
007f27e
Update Node Versions and types to fix latest tsc upgrade issues
Oct 2, 2025
88260eb
fix playwright only test filtering that has broken from playwright br…
Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 27 additions & 16 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"dist": "./scripts/dist.sh && npm run types-generate && npm run web-types-generate",
"lint": "eslint src/htmx.js test/attributes/ test/core/ test/util/ scripts/*.mjs",
"format": "eslint --fix src/htmx.js test/attributes/ test/core/ test/util/ scripts/*.mjs",
"types-check": "tsc src/htmx.js --noEmit --checkJs --target es6 --lib dom,dom.iterable",
"types-check": "tsc src/htmx.js --noEmit --checkJs --target es6 --lib dom,dom.iterable --moduleResolution node",
"types-generate": "tsc dist/htmx.esm.js --declaration --emitDeclarationOnly --allowJs --outDir dist",
"test": "npm run lint && npm run types-check && npm run test:chrome",
"test:debug": "web-test-runner --manual --open",
Expand Down Expand Up @@ -70,8 +70,8 @@
"no-useless-escape": 0,
"no-unused-expressions": 0,
"no-restricted-properties": ["error", {
"property": "substr",
"message": "Use .slice or .substring instead of .substr"
"property": "substr",
"message": "Use .slice or .substring instead of .substr"
}],
"space-before-function-paren": [
"error",
Expand All @@ -80,7 +80,7 @@
}
},
"devDependencies": {
"@types/node": "20.0.0",
"@types/node": "^22.18.8",
"@types/parse5": "^7.0.0",
"@web/test-runner": "^0.20.2",
"@web/test-runner-playwright": "^0.11.0",
Expand All @@ -91,10 +91,10 @@
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-mocha": "^10.5.0",
"fs-extra": "^9.1.0",
"mocha": "^11.1.0",
"mocha": "^11.7.4",
"mock-socket": "^9.3.1",
"sinon": "^10.0.1",
"typescript": "^5.5.4",
"typescript": "^5.9.3",
"uglify-js": "^3.19.3",
"ws": "^8.18.1"
}
Expand Down
2 changes: 1 addition & 1 deletion test/attributes/hx-boost.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ describe('hx-boost attribute', function() {
div.innerHTML.should.equal('Boosted!')
})

if (window.__playwright__binding__ && /chrome/i.test(navigator.userAgent)) {
if (/headlesschrome/i.test(navigator.userAgent)) {
it('ctrlKey mouse click does not boost', function() {
// Test only works well in playwright with chome for code coverage as otherwise it opens a new tab breaking things
this.server.respondWith('GET', '/test', 'Boosted')
Expand Down
2 changes: 1 addition & 1 deletion test/attributes/hx-trigger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,7 @@ describe('hx-trigger attribute', function() {
}, 250)
})

if (window.__playwright__binding__) {
if (/headlesschrome/i.test(navigator.userAgent)) {
it('scrolling triggers intersect event', function(done) {
// test only works reliably with playwright
this.server.respondWith('GET', '/test', 'test')
Expand Down