Fix restoreFocus when focus is lost on an element with a numeric id#127
Merged
botandrose merged 2 commits intomainfrom Feb 27, 2025
Merged
Fix restoreFocus when focus is lost on an element with a numeric id#127botandrose merged 2 commits intomainfrom
botandrose merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #125, I found another place in the code where we were assuming that it was safe to prepend
#to an ID and have a valid CSS selector: the focus restoration code.First commit is a failing test to expose the issue, and the second is the same fix as applied in #125.