Skip to content

Fix restoreFocus when focus is lost on an element with a numeric id #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
botandrose merged 2 commits into from
Feb 27, 2025
Merged

Fix restoreFocus when focus is lost on an element with a numeric id #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb70e57
failing test to demonstrate issue with restoring focus on a numeric id.
botandrose-machine Feb 26, 2025
88a0218
fix error when trying to restore focus on an element with a numeric id.
botandrose-machine Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/idiomorph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ var Idiomorph = (function () {
const results = fn();

if (activeElementId && activeElementId !== document.activeElement?.id) {
activeElement = ctx.target.querySelector(`#${activeElementId}`);
activeElement = ctx.target.querySelector(`[id="${activeElementId}"]`);
activeElement?.focus();
}
if (activeElement && !activeElement.selectionEnd && selectionEnd) {
Expand Down
19 changes: 19 additions & 0 deletions test/restore-focus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,25 @@ describe("Option to forcibly restore focus after morph", function () {
assertFocus("focused");
});

it("restores focus state with reparented numeric id", function () {
assertFocusPreservationWithoutMoveBefore(
`
<div>
<input type="text" id="other">
<div>
<input type="text" id="1" value="abc">
</div>
</div>`,
`
<div>
<input type="text" id="other">
<input type="text" id="1" value="abc">
</div>`,
"1",
"b",
);
});

it("preserves focus state when focused element is moved between anonymous containers", function () {
assertFocusPreservationWithoutMoveBefore(
`
Expand Down