Skip to content

Update numpy, scipy, scikit-learn deps#55

Merged
markotoplak merged 4 commits intobiolab:masterfrom
markotoplak:update_libs
Oct 23, 2024
Merged

Update numpy, scipy, scikit-learn deps#55
markotoplak merged 4 commits intobiolab:masterfrom
markotoplak:update_libs

Conversation

@markotoplak
Copy link
Member

No description provided.

@markotoplak
Copy link
Member Author

test_run_with_sparse_matrix_ignores_normalization and test_normalized_gives_correct_result fails are there because biolab/orange3#6815. These are the only issues in the non-conda Windows Installer and x86 Mac. These issues also appear on -oldest tests on orange3.

Arm Macs have additional issues: Orange.tests.test_random_forest.RandomForestTest.test_max_features_reg and Orange.widgets.evaluate.tests.test_owpermutationplot.TestOWPermutationPlot.test_info, which also fail on MacOS tests on orange3.

Windows conda release has an unknown issue though:

======================================================================
FAIL: test_expression (Orange.widgets.model.tests.test_owcurvefit.TestOWCurveFit.test_expression)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\test-install\Lib\site-packages\Orange\widgets\model\tests\test_owcurvefit.py", line 373, in test_expression
    self.assertIsNotNone(model)
AssertionError: unexpectedly None

@markotoplak
Copy link
Member Author

Test expression is not a problem in releases/3.37.0, which is on scikit-learn 1.3, so maybe 1.4 is the problem.

@markotoplak markotoplak marked this pull request as draft June 7, 2024 09:00
@markotoplak
Copy link
Member Author

Conda installer is not tested here because new deps are not compatible with the released Orange version.

@markotoplak markotoplak marked this pull request as ready for review October 18, 2024 12:53
@markotoplak
Copy link
Member Author

This updates scikit-learn to the required version, scipy to 1.13, before some sparse deprecations (orange3 works perfectly with 1.14 too, just keeping safe for addons), numpy to 1.26 (out for more than a year now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant