Document Embedding: better error messages #1133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
requested changes
Jul 17, 2025
Member
markotoplak
left a comment
markotoplak
left a comment
There was a problem hiding this comment.
Most importantly, error messages should contain the actual server address that
we could not connect to. That alone would make connection errors easier to debug (for advanced users), as we discussed live.
If I remember our discussions with @VesnaT, main issues with the PR were not resolved. See the two code comments. If they are not clear, please contact me.
leskovecg
force-pushed
the
fix-embedder-connection-tests
branch
3 times, most recently
from
8ab24b6 to
e1ca92f
Compare
leskovecg
force-pushed
the
fix-embedder-connection-tests
branch
from
e1ca92f to
a41c7ce
Compare
This was referenced Aug 4, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1109 – Improves the error handling in the Document Embedding widget when there is no internet connection or when the server is not responding.
Description of changes
Additional notes
A few test failures appeared during CI that are unrelated to this PR and stem from other parts of the codebase (e.g., OWImportDocuments, CorpusViewer). I will address those in separate PRs to keep this one focused and clean.
Includes