[FIX] OWBaseLearner: Do not re-fit if name has changed#1580
Merged
lanzagar merged 1 commit intobiolab:masterfrom Sep 30, 2016
Merged
[FIX] OWBaseLearner: Do not re-fit if name has changed#1580lanzagar merged 1 commit intobiolab:masterfrom
lanzagar merged 1 commit intobiolab:masterfrom
Conversation
When the name of the learner had been changed, the entire model was re-calculated.
Current coverage is 88.69% (diff: 100%)@@ master #1580 diff @@
==========================================
Files 78 78
Lines 8108 8108
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7191 7191
Misses 917 917
Partials 0 0
|
ajdapretnar
reviewed
Sep 21, 2016
Contributor
ajdapretnar
left a comment
ajdapretnar
left a comment
There was a problem hiding this comment.
It is not working for me. When changing the name only, the entire model still gets re-calculated.
Contributor
|
It probably doesn't re-calculate the model. Instead, the recipient widgets are sent the model again (Test & Score runs again, for example). |
lanzagar
approved these changes
Sep 30, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the name of the learner had been changed, the entire model was re-calculated.