Skip to content

[FIX] OWBaseLearner: Do not re-fit if name has changed #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lanzagar merged 1 commit into from
Sep 30, 2016
Merged

[FIX] OWBaseLearner: Do not re-fit if name has changed #1580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Orange/widgets/utils/owlearnerwidget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,16 @@ def settings_changed(self, *args, **kwargs):
self.Warning.outdated_learner(shown=not self.auto_apply)
self.apply()

def _change_name(self, instance, signal_name):
if instance:
instance.name = self.learner_name
if self.auto_apply:
self.send(signal_name, instance)

def learner_name_changed(self):
self._change_name(self.learner, "Learner")
self._change_name(self.model, self.OUTPUT_MODEL_NAME)

def send_report(self):
self.report_items((("Name", self.learner_name),))

Expand Down Expand Up @@ -227,7 +237,7 @@ def add_learner_name_widget(self):
self.name_line_edit = gui.lineEdit(
self.controlArea, self, 'learner_name', box='Name',
tooltip='The name will identify this model in other widgets',
orientation=Qt.Horizontal, callback=lambda: self.apply())
orientation=Qt.Horizontal, callback=self.learner_name_changed)

def add_bottom_buttons(self):
box = gui.hBox(self.controlArea, True)
Expand Down