[FIX] WebviewWidget: WebEngine Don't Grab Focus on setHtml

[nikicc]

Issue

If running on WebEngine the call to setHtml grabs focus and sets it to WebViewWidget. This is quite annoying behaviour when for example one would like to filter some data set and show the results in WebView. Due to WebViewWidget's focus grabbing the input filter looses focus after every character is typed.

Description of changes

Override setHtml to that the widget's state is first set to disabled, then call super().setHtlm and finally restore the initial state.

Includes

• Code changes
• Tests
• Documentation

[codecov-io]

Codecov Report

Merging #1983 into master will decrease coverage by -0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #1983      +/-   ##
==========================================
- Coverage   70.22%   70.21%   -0.01%     
==========================================
  Files         343      343              
  Lines       54092    54097       +5     
==========================================
+ Hits        37984    37985       +1     
- Misses      16108    16112       +4

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70f0e1b...6a5a8bc. Read the comment docs.

[lanzagar]

I don't have the mentioned problem (using qt 5.8). But the fix does not seem to break anything for me either. Could you add a TODO or something like that to the comment and mention that this might be fixed in newer versions, so that we can remove the fix in the future if it will not be necessary anymore.

[astaric]

I could not reproduce this either (I'm using Qt 5.6).

[ajdapretnar]

I have the bug. (Qt 5.6)

[nikicc]

@astaric running on anaconda?

[nikicc]

@lanzagar I added the comment.

@astaric these are the packages I have installed in my conda env. Are you running the same versions and cannot reproduce? Are you running WebKit or WebEngine?

anyqt                     0.0.7                    py35_1    conda-forge
pyqt                      5.6.0                    py35_2
pyqtgraph                 0.10.0                   py35_0    conda-forge
qt                        5.6.2                         0