[FIX] Update checker: LooseVersion doesn't handle str parts#2401
Merged
lanzagar merged 1 commit intobiolab:masterfrom Jun 16, 2017
Merged
[FIX] Update checker: LooseVersion doesn't handle str parts#2401lanzagar merged 1 commit intobiolab:masterfrom
lanzagar merged 1 commit intobiolab:masterfrom
Conversation
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #2401 +/- ##
==========================================
- Coverage 73.88% 73.88% -0.01%
==========================================
Files 322 322
Lines 55843 55843
==========================================
- Hits 41262 41257 -5
- Misses 14581 14586 +5 |
jerneju
approved these changes
Jun 13, 2017
Member
|
Are you sure this one handles everything? Would it be possilble to add some tests? |
Member
|
PS. Could you also add a trailing / to the URL used to check the version (to avoid unnecessary redirects)? |
E.g., '3.4.1' vs '3.4.dev' crashes on 'dev' with TypeError and unorderable types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Use newer
package_resources.SetuptoolsVersionwhich doesn't exhibit this problem.Includes