[FIX] Statistics.unique: Fix Sparse Return Order For Negative Numbers#2572
Merged
nikicc merged 2 commits intobiolab:masterfrom Oct 21, 2017
Merged
[FIX] Statistics.unique: Fix Sparse Return Order For Negative Numbers#2572nikicc merged 2 commits intobiolab:masterfrom
nikicc merged 2 commits intobiolab:masterfrom
Conversation
11eee67 to
3a2f4f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2572 +/- ##
==========================================
- Coverage 75.83% 75.83% -0.01%
==========================================
Files 338 338
Lines 59545 59545
==========================================
- Hits 45156 45154 -2
- Misses 14389 14391 +2 |
792b230 to
08238b1
Compare
08238b1 to
8add499
Compare
Collaborator
Author
Contributor
|
OK, then when #2558 is merged this just needs a rebase and IMO it's ready to merge. |
447fd36 to
bc688c8
Compare
3 tasks
326d512 to
28ceda0
Compare
Contributor
|
Please rebase this as #2698 has been merged. |
28ceda0 to
c5a3368
Compare
c5a3368 to
3e08ba0
Compare
Collaborator
Author
|
@nikicc Rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
uniquereturned incorrectly ordered arrays in case of a negative number e.g.nanuniquedid not support any parameters thatuniquesupported.Description of changes
Fixes above issues. This PR depends on #2698 for the
dense_sparsetesting utility.Includes