Skip to content

[FIX] owhierarchicalclustering: Fix performance on deselection #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerneju merged 1 commit into from
Oct 12, 2017
Merged

[FIX] owhierarchicalclustering: Fix performance on deselection #2670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Orange/widgets/unsupervised/owhierarchicalclustering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ def select_item(self, item, state):
if item in self._selection:
if state == False:
self._remove_selection(item)
self._re_enumerate_selections()
self.selectionChanged.emit()
else:
# If item is already inside another selected item,
Expand All @@ -455,11 +456,11 @@ def select_item(self, item, state):

if state:
self._add_selection(item)
self._re_enumerate_selections()

elif item in self._selection:
self._remove_selection(item)

self._re_enumerate_selections()
self.selectionChanged.emit()

def _add_selection(self, item):
Expand Down Expand Up @@ -499,8 +500,6 @@ def _remove_selection(self, item):

del self._selection[item]

self._re_enumerate_selections()

def _selected_sub_items(self, item):
"""Return all selected subclusters under item."""
def branches(item):
Expand Down