[ENH] Scatter Plot Graph: max discrete values colors and shape#2804
Merged
lanzagar merged 3 commits intobiolab:masterfrom Dec 11, 2017
jerneju:spg-discrete
Merged
[ENH] Scatter Plot Graph: max discrete values colors and shape#2804lanzagar merged 3 commits intobiolab:masterfrom jerneju:spg-discrete
lanzagar merged 3 commits intobiolab:masterfrom
jerneju:spg-discrete
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2804 +/- ##
==========================================
+ Coverage 76.2% 76.21% +0.01%
==========================================
Files 337 337
Lines 59665 59697 +32
==========================================
+ Hits 45470 45501 +31
- Misses 14195 14196 +1 |
lanzagar
requested changes
Dec 6, 2017
Contributor
lanzagar
left a comment
There was a problem hiding this comment.
- I have a much worse color pallete (gradient from red to blue with many similar colors).
- Triangle appears twice in shapes
- "Other" marker does not have the right color in the picture (different from legend)
- Maybe for next PR : picture and legend should have the exact same colors/symbols
Contributor
Author
Color palette is variable dependent. See |
Contributor
Which means your changes here are problematic because they do not handle this... |
3 tasks
lanzagar
approved these changes
Dec 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2782
Description of changes
Includes