[FIX] owkmeans: fix initialization choice#3090
Merged
Conversation
Contributor
|
Nice catch. While you are fixing this, could you improve this one step further and remove the constants in the middle of the code? |
044c321 to
aff45be
Compare
Codecov Report
@@ Coverage Diff @@
## master #3090 +/- ##
==========================================
+ Coverage 82.42% 82.43% +<.01%
==========================================
Files 335 335
Lines 58037 58048 +11
==========================================
+ Hits 47838 47849 +11
Misses 10199 10199 |
Member
Author
|
@lanzagar, thank you, I did as you suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Initialization (random or k-means++) was wrongly passed from widget to the library.
Includes