Skip to content

[FIX] Scatterplot: Enable/disable vizrank button#4016

Merged
janezd merged 1 commit intobiolab:masterfrom
VesnaT:scatterplot_vizrank_button
Sep 13, 2019
Merged

[FIX] Scatterplot: Enable/disable vizrank button#4016
janezd merged 1 commit intobiolab:masterfrom
VesnaT:scatterplot_vizrank_button

Conversation

@VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Sep 11, 2019

Issue

Vizrank button was disabled for datasets with a constant feature.

Description of changes

Enable the button for datasets with a constant feature.
Add a tooltip on the button with a reason for disabling it.

Includes
  • Code changes
  • Tests
  • Documentation

@VesnaT VesnaT changed the title Scatterplot: Enable/disable vizrank button [FIX] Scatterplot: Enable/disable vizrank button Sep 11, 2019
Copy link
Contributor

@janezd janezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this PR as it is. But please review my comments. Feel free to reject them if you disagree.

@janezd janezd self-assigned this Sep 12, 2019
@VesnaT VesnaT force-pushed the scatterplot_vizrank_button branch from bebda4c to 8705073 Compare September 13, 2019 06:23
@janezd janezd merged commit 7af0ad9 into biolab:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants