Skip to content

[FIX] Feature Statistics: Do not crash on empty domain#4245

Merged
janezd merged 1 commit intobiolab:masterfrom
lanzagar:featstat-noattrs
Dec 6, 2019
Merged

[FIX] Feature Statistics: Do not crash on empty domain#4245
janezd merged 1 commit intobiolab:masterfrom
lanzagar:featstat-noattrs

Conversation

@lanzagar
Copy link
Contributor

@lanzagar lanzagar commented Dec 4, 2019

Issue

Feature Statistics crashes on data with an empty Domain.
To reproduce: File (iris) -> Select Columns (remove everything) -> Feature Statistics

Description of changes

Sort only if there is something to sort.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #4245 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4245      +/-   ##
==========================================
+ Coverage   86.05%   86.05%   +<.01%     
==========================================
  Files         394      394              
  Lines       70227    70230       +3     
==========================================
+ Hits        60432    60437       +5     
+ Misses       9795     9793       -2

@janezd janezd self-assigned this Dec 6, 2019
@janezd janezd merged commit f53e107 into biolab:master Dec 6, 2019
@lanzagar lanzagar deleted the featstat-noattrs branch March 14, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants