[ENH] Automated and better summaries by janezd · Pull Request #5308 · biolab/orange3

janezd · 2021-03-04T12:47:04Z

Issue

Ref: #5108

Requires: biolab/orange-widget-base#136.

Description of changes

See biolab/orange-widget-base#136.

Includes

Code changes
Tests
Documentation

janezd · 2021-03-04T14:26:42Z

Orange/widgets/utils/state_summary.py

    return '<hr>'.join(full_details)
+
+
+@summarize.register(Table)


If we stop supporting Python 3.6, it would suffice to annotate the function's argument as Table instead of passing Table to decorator.

According to NEP 29, we've been free to drop 3.6 since Jun 23, 2020. The only concern would be Anaconda (for the same reason we still tacitly support PyQt5.9).
https://numpy.org/neps/nep-0029-deprecation_policy.html

irgolic · 2021-03-12T11:12:50Z

/rebase

janezd · 2021-03-12T11:32:54Z

Rebase alone won't help. This requires a new release of orange-widget-base because of from orangewidget.utils.signals import summarize, PartialSummary. :(

VesnaT · 2021-03-16T08:58:37Z

Orange/widgets/visualize/utils/widget.py

        self._invalidated = True
        self._domain_invalidated = True
-        self.input_changed.connect(self.set_input_summary)
-        self.output_changed.connect(self.set_output_summary)


Are the signals (input_changed and output_changed) still needed?

You tell me.

I'd prefer if they're eliminated. (Otherwise every widget could have them.)

Please keep them. I know we separated the repositories, but we need the API between canvas/widget-base. I'd love to be able to read/write a widget's title from OWWidget code, too.

@irgolic, this signal doesn't help you a lot. This is OWDataProjectionWidget, not OWBaseWidget. You want to keep it here or have it there?

Sorry, I got it confused with this. https://orange-canvas-core.readthedocs.io/en/0.1.16/orangecanvas/scheme.events.html#orangecanvas.scheme.events.WorkflowEvent.OutputLinkAdded
By all means, remove these signals. :)

PrimozGodec · 2021-04-30T12:09:49Z

widget-base is now released.

codecov · 2021-04-30T14:13:30Z

Codecov Report

Merging #5308 (a2c278b) into master (ccea9ca) will decrease coverage by 0.21%.
The diff coverage is 97.91%.

@@            Coverage Diff             @@
##           master    #5308      +/-   ##
==========================================
- Coverage   86.37%   86.15%   -0.22%     
==========================================
  Files         303      303              
  Lines       62157    61592     -565     
==========================================
- Hits        53688    53065     -623     
- Misses       8469     8527      +58

janezd · 2021-04-30T14:56:58Z

@VesnaT, I think this is ready (rebased, corrected and linted).

VesnaT

Some observations:

CSV File Import widget does not display the summary
the summary code can be removed from Aggregate columns widget

VesnaT · 2021-05-04T11:23:38Z

Orange/widgets/utils/state_summary.py

+
+summarize_by_name(Model, "&#9924;" if date.month == 12 else "🄼")
+summarize_by_name(Learner, "🄻")
+summarize_by_name(Preprocess, "🄿")


Have you considered displaying all preprocessors in case of PreprocessorList?

I haven't. Now I did. Names are not nice -- they are class names. But that's all we have.

VesnaT · 2021-05-04T11:47:06Z

Orange/widgets/evaluate/owpredictions.py

    def _get_details(self):
        details = "Data:<br>"
-        details += format_summary_details(self.data).replace('\n', '<br>') if \
+        details += format_summary_details(self.data, format=Qt.RichText) if \


The if part can now be removed.

VesnaT · 2021-05-04T11:54:44Z

Orange/widgets/visualize/utils/widget.py

        self.__pending_selection = self.selection
        self._invalidated = True
        self._domain_invalidated = True
-        self.input_changed.connect(self.set_input_summary)


The signals are no longer user and can be removed.

They already were.

janezd · 2021-05-06T13:16:35Z

CSV File Import widget does not display the summary

And I thought I checked them all. The problem was that it used old-style output signals. I migrated it to new signals.

the summary code can be removed from Aggregate columns widget

This widget was moved from prototypes after I prepared this PR. :) Fixed.

Co-authored-by: Rafael Irgolic <hello@irgolic.com>

janezd force-pushed the auto-summary branch from 0248d42 to 3636285 Compare March 4, 2021 13:38

janezd changed the title ~~[RFC] Automated output summary~~ [RFC] Automated summaries Mar 4, 2021

janezd force-pushed the auto-summary branch from 3636285 to 383f04d Compare March 4, 2021 14:24

janezd commented Mar 4, 2021

View reviewed changes

janezd force-pushed the auto-summary branch 2 times, most recently from 087a2ae to e2d90dc Compare March 6, 2021 20:18

janezd mentioned this pull request Mar 6, 2021

Add automated summaries biolab/orange-widget-base#136

Merged

3 tasks

janezd force-pushed the auto-summary branch 2 times, most recently from 3fbbfe9 to ef9fc8f Compare March 7, 2021 10:06

janezd added the needs discussion Core developers need to discuss the issue label Mar 11, 2021

janezd changed the title ~~[RFC] Automated summaries~~ [ENH] Automated and better summaries Mar 11, 2021

janezd force-pushed the auto-summary branch 2 times, most recently from 7365d18 to 514f857 Compare March 12, 2021 10:06

janezd removed the needs discussion Core developers need to discuss the issue label Mar 12, 2021

janezd force-pushed the auto-summary branch from 514f857 to 032f45f Compare March 12, 2021 11:30

janezd added the waiting for new dependency version Depends on unreleased orange-canvas-core/orange-widget-base content label Mar 12, 2021

VesnaT reviewed Mar 16, 2021

View reviewed changes

janezd mentioned this pull request Mar 27, 2021

Fix calls to set_domain #5324

Merged

2 tasks

VesnaT mentioned this pull request Apr 12, 2021

Preprocess: Automated summaries compatibility biolab/orange3-text#647

Merged

3 tasks

janezd assigned janezd and VesnaT Apr 30, 2021

janezd force-pushed the auto-summary branch 2 times, most recently from 23e80da to 7954dd5 Compare April 30, 2021 14:01

janezd force-pushed the auto-summary branch from 7954dd5 to e38f23b Compare April 30, 2021 14:42

janezd removed their assignment Apr 30, 2021

janezd removed the waiting for new dependency version Depends on unreleased orange-canvas-core/orange-widget-base content label Apr 30, 2021

VesnaT reviewed May 4, 2021

View reviewed changes

janezd force-pushed the auto-summary branch from e38f23b to 1f4bef0 Compare May 6, 2021 13:21

janezd and others added 3 commits May 6, 2021 16:42

state_summary: Provide classes for automated output summary

ca4dfe9

Use automated summaries

f2da678

Co-authored-by: Rafael Irgolic <hello@irgolic.com>

OWCSVImport: Use new-style signals to enable auto summaries

a2c278b

janezd force-pushed the auto-summary branch from 1f4bef0 to a2c278b Compare May 6, 2021 14:42

VesnaT merged commit ce6222e into biolab:master May 7, 2021

janezd mentioned this pull request May 7, 2021

Automatically set input/output summary #5108

Closed

Uh oh!

Conversation

janezd commented Mar 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Description of changes

Includes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

irgolic commented Mar 12, 2021

Uh oh!

janezd commented Mar 12, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PrimozGodec commented Apr 30, 2021

Uh oh!

codecov bot commented Apr 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

janezd commented Apr 30, 2021

Uh oh!

VesnaT left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

janezd commented May 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

janezd commented Mar 4, 2021 •

edited

Loading

codecov bot commented Apr 30, 2021 •

edited

Loading