feat(analyze/html/vue): add `useVueVForKey` #8587

dyc3 · 2025-12-27T16:11:01Z

Summary

This adds useVueVForKey, a port of https://eslint.vuejs.org/rules/require-v-for-key.html

The first draft was written by AI, but I effectively rewrote the whole thing myself.

Test Plan

snapshots

Docs

changeset-bot · 2025-12-27T16:11:04Z

🦋 Changeset detected

Latest commit: e9eb0d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dyc3 · 2025-12-27T16:11:25Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

ematipico

Code can be optimised. I left my option on the diagnostic, it's a nit

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

coderabbitai · 2025-12-28T21:44:07Z

Walkthrough

Adds a new HTML lint rule useVueVForKey that enforces Vue v-for usages include a key (shorthand :key or v-bind:key). Implements the rule at crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs with detection and diagnostics, and declares the rule via declare_lint_rule!. Adds UseVueVForKeyOptions in crates/biome_rule_options/src/use_vue_v_for_key.rs and exposes the module from crates/biome_rule_options/src/lib.rs. Includes test fixtures tests/specs/nursery/useVueVForKey/{valid.vue,invalid.vue} and a changelog entry documenting the rule.

Suggested reviewers

ematipico

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarises the main change: adding the useVueVForKey linter rule for Vue v-for key validation.
Description check	✅ Passed	The description clearly relates to the changeset, explaining the motivation (porting an ESLint rule) and noting AI assistance disclosure.

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codspeed-hq · 2025-12-28T21:45:56Z

CodSpeed Performance Report

Merging #8587 will not alter performance

_{Comparing dyc3/use-vue-v-for-key (e9eb0d1) with main (e295960)}

Summary

✅ 1 untouched
⏩ 154 skipped¹

154 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

crates/biome_rule_options/src/use_vue_v_for_key.rs (1)
1-6: Consider adding a brief rustdoc comment.

Per coding guidelines, inline rustdoc documentation should be used for rule options. Even for an empty struct, a one-liner explaining it's a placeholder for future options would help.
🔎 Suggested addition
 use biome_deserialize_macros::{Deserializable, Merge};
 use serde::{Deserialize, Serialize};
+
+/// Options for the `useVueVForKey` rule.
 #[derive(Default, Clone, Debug, Deserialize, Deserializable, Merge, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
 #[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct UseVueVForKeyOptions {}

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe1c378 and e9eb0d1.

⛔ Files ignored due to path filters (7)

crates/biome_configuration/src/analyzer/linter/rules.rs is excluded by !**/rules.rs and included by **
crates/biome_diagnostics_categories/src/categories.rs is excluded by !**/categories.rs and included by **
crates/biome_html_analyze/src/lint/nursery.rs is excluded by !**/nursery.rs and included by **
crates/biome_html_analyze/tests/specs/nursery/useVueVForKey/invalid.vue.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/nursery/useVueVForKey/valid.vue.snap is excluded by !**/*.snap and included by **
packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
packages/@biomejs/biome/configuration_schema.json is excluded by !**/configuration_schema.json and included by **

📒 Files selected for processing (6)

.changeset/add-v-for-key-rule.md
crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs
crates/biome_html_analyze/tests/specs/nursery/useVueVForKey/invalid.vue
crates/biome_html_analyze/tests/specs/nursery/useVueVForKey/valid.vue
crates/biome_rule_options/src/lib.rs
crates/biome_rule_options/src/use_vue_v_for_key.rs

🚧 Files skipped from review as they are similar to previous changes (3)

crates/biome_rule_options/src/lib.rs
crates/biome_html_analyze/tests/specs/nursery/useVueVForKey/invalid.vue
crates/biome_html_analyze/tests/specs/nursery/useVueVForKey/valid.vue

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.rs: Use inline rustdoc documentation for rules, assists, and their options
Use the dbg!() macro for debugging output in Rust tests and code
Use doc tests (doctest) format with code blocks in rustdoc comments; ensure assertions pass in tests

Files:

crates/biome_rule_options/src/use_vue_v_for_key.rs
crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

🧠 Learnings (28)

📓 Common learnings

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `declare_lint_rule!` macro to declare analyzer rule types and implement the RuleMeta trait

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Add `deprecated` field to `declare_lint_rule!` macro when deprecating a rule

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Set `version` field to `next` in `declare_lint_rule!` macro

Learnt from: dyc3
Repo: biomejs/biome PR: 8639
File: crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs:101-108
Timestamp: 2025-12-31T15:35:41.261Z
Learning: In crates/biome_analyze/**/*analyze/src/lint/nursery/**/*.rs, the `issue_number` field in `declare_lint_rule!` macro is optional and the vast majority of nursery rules do not need it. Do not recommend adding `issue_number` unless there's a specific reason.

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/nursery/**/*.rs : Place new rules inside the `nursery` group during development

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Specify `fix_kind: FixKind::Safe` in `declare_lint_rule!` for safe code actions

Learnt from: ematipico
Repo: biomejs/biome PR: 8537
File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:167-210
Timestamp: 2025-12-22T09:27:13.161Z
Learning: In crates/biome_analyze/**/*analyze/src/**/*.rs, the `fix_kind` field in `declare_lint_rule!` should only be specified when the rule implements the `action` function. Rules that only emit diagnostics without providing code fixes should not include `fix_kind` in their metadata.

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `options` code block property for rule-specific configuration snippets in documentation

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Set `language` field in `declare_lint_rule!` macro to the language the rule primarily applies to

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Specify `fix_kind: FixKind::Unsafe` in `declare_lint_rule!` for unsafe code actions

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Use `deny_unknown_fields` in serde derive macro for rule options

Applied to files:

crates/biome_rule_options/src/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Use `rename_all = "camelCase"` in serde derive macro for rule options

Applied to files:

crates/biome_rule_options/src/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Wrap rule options fields in `Option<>` to properly track set and unset options during merge

Applied to files:

crates/biome_rule_options/src/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Rule options struct must derive `Deserializable`, `Serialize`, `Deserialize`, and optionally `JsonSchema`

Applied to files:

crates/biome_rule_options/src/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Use `Box<[T]>` instead of `Vec<T>` for rule options arrays to save memory

Applied to files:

crates/biome_rule_options/src/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Implement `Merge` trait for rule options to support configuration inheritance

Applied to files:

crates/biome_rule_options/src/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `use_options` code block property for code examples that follow an options configuration in documentation

Applied to files:

crates/biome_rule_options/src/use_vue_v_for_key.rs

📚 Learning: 2025-11-24T18:05:42.356Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:42.356Z
Learning: Applies to crates/biome_js_type_info/**/*.rs : Distinguish between `TypeData::Unknown` and `TypeData::UnknownKeyword` to measure inference effectiveness versus explicit user-provided unknown types

Applied to files:

crates/biome_rule_options/src/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `options` code block property for rule-specific configuration snippets in documentation

Applied to files:

crates/biome_rule_options/src/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Rule options must be placed inside the `biome_rule_options` crate

Applied to files:

crates/biome_rule_options/src/use_vue_v_for_key.rs

📚 Learning: 2025-12-21T21:15:03.796Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-21T21:15:03.796Z
Learning: For new lint rules in changesets, show an example of invalid case in inline code or code block

Applied to files:

.changeset/add-v-for-key-rule.md

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Set `version` field to `next` in `declare_lint_rule!` macro

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-31T15:35:32.899Z

Learnt from: dyc3
Repo: biomejs/biome PR: 8639
File: crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs:101-108
Timestamp: 2025-12-31T15:35:32.899Z
Learning: In Rust lint rules under the nursery category, the issue_number field in declare_lint_rule! is optional and should not be added unless there is a compelling reason. In code reviews, verify that no unnecessary issue_number is included in nursery lint declarations. Only add issue_number if there is an explicit, justified reason (e.g., tracked issue for external observers). This guidance broadly applies to all nursery lint rule files, not just the single file.

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `declare_lint_rule!` macro to declare analyzer rule types and implement the RuleMeta trait

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-22T09:26:56.943Z

Learnt from: ematipico
Repo: biomejs/biome PR: 8537
File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:167-210
Timestamp: 2025-12-22T09:26:56.943Z
Learning: When defining lint rules (declare_lint_rule!), only specify fix_kind if the rule implements an action(...) function. Rules that only emit diagnostics without a code fix should omit fix_kind. This applies to all Rust lint rule definitions under crates/.../src/lint (e.g., crates/biome_js_analyze/src/lint/...).

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Add `deprecated` field to `declare_lint_rule!` macro when deprecating a rule

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/nursery/**/*.rs : Place new rules inside the `nursery` group during development

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `RuleSource::Eslint(...).same()` when implementing a rule that matches the behavior of an ESLint rule

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `domains` field in `declare_lint_rule!` to tag rules that belong to specific concepts like testing or frameworks

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Specify `fix_kind: FixKind::Safe` in `declare_lint_rule!` for safe code actions

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Add `sources` field with `RuleSource` to cite ESLint or other rules that inspired the implementation

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `RuleSource::Eslint(...).inspired()` when implementing a rule inspired by but with different behavior than an ESLint rule

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Lint rules should perform static analysis of source code to detect invalid or error-prone patterns and emit diagnostics with proposed fixes

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Lint rules should check syntax according to language specification and emit error diagnostics

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Each invalid code example in rule documentation must emit exactly one diagnostic

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Rule documentation code blocks should be ordered as language, expect_diagnostic, options/full_options/use_options, ignore, file

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

📚 Learning: 2025-12-19T12:53:30.413Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.413Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use language-specific rule names if the rule is meant for a specific language only

Applied to files:

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: Test Node.js API
GitHub Check: Bench (biome_configuration)
GitHub Check: autofix
GitHub Check: Check JS Files
GitHub Check: Documentation
GitHub Check: End-to-end tests
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Check Dependencies
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Test (depot-windows-2022-16)

🔇 Additional comments (5)

.changeset/add-v-for-key-rule.md (1)

1-17: LGTM!

Well-documented changeset with clear invalid/valid examples. Based on learnings, this follows the recommended pattern for new lint rule changesets.

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs (4)

9-45: LGTM!

Rule declaration follows all conventions: version: "next", proper sources with .same(), domains for Vue, and well-documented examples with expect_diagnostic. The Vue docs link is a nice touch. Based on learnings, this is correctly structured for a nursery rule.

53-90: LGTM!

The detection logic is sound. The early exit when both v-for and key are found is a sensible optimisation. The tuple pattern match at line 86-88 neatly handles the "v-for present but key absent" case.

92-108: LGTM!

Clear diagnostic message with helpful notes. The Vue docs link and inline example give users actionable guidance.

111-121: LGTM!

Clean helper function with appropriate early returns for error cases.

dyc3 · 2026-01-02T04:10:49Z

Merge activity

Jan 2, 4:10 AM UTC: A user started a stack merge that includes this pull request via Graphite.
Jan 2, 4:11 AM UTC: @dyc3 merged this pull request with Graphite.

dyc3 mentioned this pull request Dec 27, 2025

feat(analyze/html/vue): add a few more simple vue lint rules #8583

Merged

dyc3 mentioned this pull request Dec 27, 2025

feat(analyze/html/vue): add v-bind/v-on style rules #8586

Merged

github-actions bot added A-Project Area: project A-Linter Area: linter A-Diagnostic Area: diagnostocis L-HTML Language: HTML and super languages labels Dec 27, 2025

dyc3 force-pushed the dyc3/use-vue-v-for-key branch from 98e9c43 to 5d6d4c0 Compare December 27, 2025 16:14

dyc3 marked this pull request as ready for review December 27, 2025 16:15

dyc3 force-pushed the dyc3/vue-directive-style-rules branch from 204192f to d45faf3 Compare December 28, 2025 18:18

dyc3 force-pushed the dyc3/use-vue-v-for-key branch from 5d6d4c0 to 391e88a Compare December 28, 2025 18:19

dyc3 mentioned this pull request Dec 28, 2025

feat(analyze/js/vue): add noVueArrowFuncInWatch #8602

Merged

ematipico approved these changes Dec 28, 2025

View reviewed changes

dyc3 changed the base branch from dyc3/vue-directive-style-rules to graphite-base/8587 December 28, 2025 20:39

dyc3 force-pushed the dyc3/use-vue-v-for-key branch from 391e88a to 14f7ca0 Compare December 28, 2025 21:34

dyc3 force-pushed the graphite-base/8587 branch from d45faf3 to 1d5df15 Compare December 28, 2025 21:34

dyc3 changed the base branch from graphite-base/8587 to dyc3/vue-directive-style-rules December 28, 2025 21:35

dyc3 changed the base branch from dyc3/vue-directive-style-rules to graphite-base/8587 December 28, 2025 21:40

dyc3 force-pushed the dyc3/use-vue-v-for-key branch from 14f7ca0 to a9e3aa3 Compare December 28, 2025 21:40

dyc3 force-pushed the graphite-base/8587 branch from 1d5df15 to df8fe06 Compare December 28, 2025 21:40

graphite-app bot changed the base branch from graphite-base/8587 to main December 28, 2025 21:40

dyc3 force-pushed the dyc3/use-vue-v-for-key branch from a9e3aa3 to 6641c36 Compare December 28, 2025 21:40

dyc3 force-pushed the dyc3/use-vue-v-for-key branch from 6641c36 to fe1c378 Compare December 28, 2025 21:48

feat(analyze/html/vue): add useVueVForKey

e9eb0d1

dyc3 force-pushed the dyc3/use-vue-v-for-key branch from fe1c378 to e9eb0d1 Compare January 2, 2026 03:40

coderabbitai bot reviewed Jan 2, 2026

View reviewed changes

dyc3 merged commit 9a8c98d into main Jan 2, 2026
18 checks passed

dyc3 deleted the dyc3/use-vue-v-for-key branch January 2, 2026 04:11

github-actions bot mentioned this pull request Jan 1, 2026

ci: release #8507

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(analyze/html/vue): add `useVueVForKey` #8587

feat(analyze/html/vue): add `useVueVForKey` #8587

Uh oh!

dyc3 commented Dec 27, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 27, 2025 •

edited

Loading

Uh oh!

dyc3 commented Dec 27, 2025 •

edited

Loading

Uh oh!

ematipico left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Dec 28, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Dec 28, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

dyc3 commented Jan 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(analyze/html/vue): add useVueVForKey #8587

feat(analyze/html/vue): add useVueVForKey #8587

Uh oh!

Conversation

dyc3 commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

dyc3 commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

codspeed-hq bot commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #8587 will not alter performance

Summary

Footnotes

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

dyc3 commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(analyze/html/vue): add `useVueVForKey` #8587

feat(analyze/html/vue): add `useVueVForKey` #8587

dyc3 commented Dec 27, 2025 •

edited

Loading

changeset-bot bot commented Dec 27, 2025 •

edited

Loading

dyc3 commented Dec 27, 2025 •

edited

Loading

coderabbitai bot commented Dec 28, 2025 •

edited

Loading

codspeed-hq bot commented Dec 28, 2025 •

edited

Loading

dyc3 commented Jan 2, 2026 •

edited

Loading