Add container selection logic #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the logic that the first container listed will be the primary container.
pinheadmz
reviewed
Oct 2, 2024
src/warnet/bitcoin.py
Outdated
| try: | ||
| pod = get_pod(tank) | ||
| container_names = [container.name for container in pod.spec.containers] | ||
| container_name = container_names[0] |
Contributor
There was a problem hiding this comment.
What determines the order of containers in a pod? Can we guarantee the one we want is always [0] because of the yaml file? Or should we hard code the name from the chart bitcoincore ?
Collaborator
Author
There was a problem hiding this comment.
The first container has been the bitcoincore container and commander container from what I have seen, but I agree that we have no way of guaranteeing that.
I changed the logic so that we use hard coded values from the constants file which match the helm charts.
Contributor
|
looks good! testing ... |
Collaborator
Author
|
Thanks @pinheadmz I'll merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the logs container selection issues in #623