-
Notifications
You must be signed in to change notification settings - Fork 54
Add container selection logic #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mplsgrant
merged 8 commits into
bitcoin-dev-project:main
from
mplsgrant:2024-10-fix-logs-container
Oct 2, 2024
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8bdbf6a
k8s: add `get_pod`
mplsgrant 23a8e21
control: fix `_logs` to look for primary container
mplsgrant 3298bc7
control: fix stream handling
mplsgrant 04352d4
bitcoin: add primary container logic to `rpc`
mplsgrant 0ab373f
make ruff happy
mplsgrant 43e3240
add constants as they appear in the helm charts
mplsgrant 8301302
use constants in the `log` function
mplsgrant 9a7a973
use constant in the bitcoin `rpc` function
mplsgrant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What determines the order of containers in a pod? Can we guarantee the one we want is always
[0]because of the yaml file? Or should we hard code the name from the chartbitcoincore?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first container has been the bitcoincore container and commander container from what I have seen, but I agree that we have no way of guaranteeing that.
I changed the logic so that we use hard coded values from the constants file which match the helm charts.