Expose Wallet::create_single method
#825
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
force-pushed
the
feature/single-descriptor-wallets
branch
from
a9880bb to
9eb3e60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
Wallet::create_single()method.I prefer to use single-descriptor wallets for my Tatooine faucet (easier to sync and keep track of), and realized we didn't bring this back into the bindings API after it was merged in Rust a while back.
TODO: Needs at least a test or two! Some methods should fail I think when the wallet is a single-descriptor, so we can test for that too.
Changelog notice
Added: - Expose `Wallet::create_single` constructor on Wallet type [#825] [#825]:Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: