-
Notifications
You must be signed in to change notification settings - Fork 67
Expose Wallet::create_single method
#825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Wallet::create_single method
#825
Conversation
a9880bb to
9eb3e60
Compare
d026c11 to
5040229
Compare
|
nice! looking pretty good, good addition. a couple small comments questions added above. then also a suggestion here would maybe be to add in so we can use Not a blocker though. |
|
Great idea @reez on cleaning up the errors on the constructor. I added that fix in a second commit. Ready for re-review! |
5040229 to
dd204ec
Compare
bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/WalletTest.kt
Outdated
Show resolved
Hide resolved
dd204ec to
53d4986
Compare
reez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 53d4986
Good addition
This PR exposes the
Wallet::create_single()method.I prefer to use single-descriptor wallets for my Tatooine faucet (easier to sync and keep track of), and realized we didn't bring this back into the bindings API after it was merged in Rust a while back.
TODO: Needs at least a test or two! Some methods should fail I think when the wallet is a single-descriptor, so we can test for that too.
Changelog notice
Added: - Expose `Wallet::create_single` constructor on Wallet type [#825] [#825]: https://github.com/bitcoindevkit/bdk-ffi/pull/825Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: