`CanonicalView` by evanlinjin · Pull Request #2029 · bitcoindevkit/bdk

evanlinjin · 2025-09-11T08:09:07Z

Description

CanonicalView allows us to canonicalize upfront, reducing our API surface and improving performance by reducing canonicalizations we need to do.

This is also the first step to achieving many of our goals.

Event notifications.
Intent tracker.
Getting rid of CanonicalUnspents structure in bdk_tx.

Changelog notice

Added
- Introduce `CanonicalView` which allows us to canonicalize once upfront.
- Added `TxGraph::canonical_view` which constructs a `CanonicalView`.

Changed
- `TxGraph` methods which require canonicalization now have `CanonicalView` equivalents.

Removed
- `TxGraph` methods which take in a fallible `ChainOracle` implementations are now removed.

Checklists

All Submissions:

I followed the contribution guidelines

New Features:

I've added tests for the new feature
I've added docs for the new feature

oleonardolima

cACK / utACK 809c153

It looks good to me so far, I left some nit and discussion comments above.

crates/chain/src/canonical_view.rs

LagginTimes · 2025-09-16T04:24:54Z

LGTM so far but needs a refactor now.

- Add `CanonicalView` structure with canonical transaction methods - Move methods from `TxGraph` to `CanonicalView` (txs, filter_outpoints, balance, etc.) - Add canonical view methods to `IndexedTxGraph` - Update all tests and examples to use new API - Optimize examples to reuse canonical view instances 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Add min_confirmations parameter to control confirmation depth requirements: - min_confirmations = 0: Include all confirmed transactions (same as 1) - min_confirmations = 1: Standard behavior - require at least 1 confirmation - min_confirmations = 6: High security - require at least 6 confirmations Transactions with fewer than min_confirmations are treated as trusted/untrusted pending based on the trust_predicate. This restores the minimum confirmation functionality that was available in the old TxGraph::balance doctest but with a more intuitive API since CanonicalView has the tip internally. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Add test file `tests/test_canonical_view.rs` with three comprehensive test cases: 1. `test_min_confirmations_parameter`: Tests basic min_confirmations functionality - Verifies min_confirmations = 0 and 1 behave identically - Tests edge case where transaction has exactly required confirmations - Tests case where transaction has insufficient confirmations 2. `test_min_confirmations_with_untrusted_tx`: Tests trust predicate interaction - Verifies insufficient confirmations + untrusted predicate = untrusted_pending - Ensures trust predicate is respected when confirmations are insufficient 3. `test_min_confirmations_multiple_transactions`: Tests complex scenarios - Multiple transactions with different confirmation counts - Verifies correct categorization based on min_confirmations threshold - Tests both min_confirmations = 5 and min_confirmations = 10 scenarios These tests validate that the min_confirmations parameter correctly controls when transactions are treated as confirmed vs trusted/untrusted pending. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

BREAKING: Remove `CanonicalTx` as it's no longer needed.

Add comprehensive docs for CanonicalView module, structs, and methods. Fix all doctests to compile and pass with proper imports.

Also update submodule-level docs for `tx_graph`'s Canonicalization section.

ValuedMammal · 2025-09-18T00:43:52Z

crates/chain/src/canonical_view.rs

+    pub fn balance<'v, O: Clone + 'v>(
+        &'v self,
+        outpoints: impl IntoIterator<Item = (O, OutPoint)> + 'v,
+        mut trust_predicate: impl FnMut(&O, ScriptBuf) -> bool,


I think trust_predicate is not expressive enough, for instance we're missing information about the txid. Using FullTxOut as the operand, we have access to more things in addition to the script pubkey.

Suggested change

mut trust_predicate: impl FnMut(&O, ScriptBuf) -> bool,

mut trust_predicate: impl FnMut(&O, &FullTxOut<A>) -> bool,

Good idea. Addressed in cb72f4a

To make it even more expressive, we can change the closure to output how many additional confirmations the UTXO needs to be considered "finalized". This will remove the additional_confirmations parameter on balance.

Wdyt?

I'm not seeing the connection between trust predicate and additional confirmations, and so I think it'd be best for them to remain separate. FTR I'm sure there's other ways for a user to filter unspents by a target number of confs, so I'm not exactly married to this approach, but it also seems convenient as most devs are already familiar with the balance method.

oleonardolima

utACK cb72f4a

BREAKING CHANGE: The trust_predicate parameter in CanonicalView::balance() now takes &FullTxOut<A> instead of ScriptBuf as its second argument. This provides more context to the predicate function. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

oleonardolima · 2025-09-24T01:26:00Z

I discussed with @evanlinjin and dropped the 7245631, which changed the min_confirmations to additional_confirmations.

~~I didn't want to rebase everything, but you probably need a rebase to get the clippy fixes.~~

evanlinjin

self-ACK 1311a2e

ValuedMammal

ACK 1311a2e

oleonardolima · 2025-09-26T01:47:42Z

I'm wondering if we should already merge this to master, as we already have breaking changes on master. And with regards to the other standalone PRs that are non-breaking, if we should merge then in a specific new branch e.g. release/0.23.3.

Let me know if you guys have another releasing approach in mind.

oleonardolima · 2025-09-26T01:54:49Z

I ran the benchmark on this PR, and so far there's no big regressions

many_conflicting_unconfirmed::list_canonical_txs
                        time:   [746.06 us 747.07 us 748.02 us]
                        change: [-0.6272% -0.4520% -0.2739%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 13 outliers among 100 measurements (13.00%)
  7 (7.00%) low mild
  6 (6.00%) high mild

many_conflicting_unconfirmed::filter_chain_txouts
                        time:   [842.09 us 844.42 us 846.63 us]
                        change: [-0.8799% +0.1490% +0.7945%] (p = 0.80 > 0.05)
                        No change in performance detected.
Found 14 outliers among 100 measurements (14.00%)
  3 (3.00%) low mild
  11 (11.00%) high mild

many_conflicting_unconfirmed::filter_chain_unspents
                        time:   [841.98 us 844.33 us 846.80 us]
                        change: [+1.2639% +1.5485% +1.8660%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

many_chained_unconfirmed::list_canonical_txs
                        time:   [5.7585 ms 5.7663 ms 5.7751 ms]
                        change: [+6.9882% +7.3202% +7.6471%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) low mild
  3 (3.00%) high mild
  1 (1.00%) high severe

many_chained_unconfirmed::filter_chain_txouts
                        time:   [5.6686 ms 5.6742 ms 5.6803 ms]
                        change: [-4.3940% -3.7067% -3.1341%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  5 (5.00%) high mild
  2 (2.00%) high severe

many_chained_unconfirmed::filter_chain_unspents
                        time:   [5.6651 ms 5.6779 ms 5.6952 ms]
                        change: [-2.2329% -1.9763% -1.7036%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
  2 (2.00%) low mild
  3 (3.00%) high mild
  4 (4.00%) high severe

nested_conflicts_unconfirmed::list_canonical_txs
                        time:   [452.26 us 452.78 us 453.35 us]
                        change: [-0.3477% -0.1279% +0.0975%] (p = 0.26 > 0.05)
                        No change in performance detected.
Found 5 outliers among 100 measurements (5.00%)
  4 (4.00%) high mild
  1 (1.00%) high severe

nested_conflicts_unconfirmed::filter_chain_txouts
                        time:   [498.89 us 499.39 us 499.91 us]
                        change: [-2.0289% -1.5397% -1.1074%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  1 (1.00%) low mild
  3 (3.00%) high mild
  1 (1.00%) high severe

nested_conflicts_unconfirmed::filter_chain_unspents
                        time:   [498.07 us 498.58 us 499.10 us]
                        change: [-1.5937% -1.1912% -0.8211%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 10 outliers among 100 measurements (10.00%)
  4 (4.00%) low mild
  2 (2.00%) high mild
  4 (4.00%) high severe

evanlinjin · 2025-09-26T02:01:27Z

@oleonardolima I don't think we need a point release for CanonicalView, it adds more work with little upside.

CanonicalView is most useful for:

Slight performance improvement (not too important).
IntentTracker - this will probably take 1-2 more months.
Removing CanonicalUnspents from bdk-tx - not used by bdk_wallet v2.x users anyway.
Events - can be done without it also.

oleonardolima

ACK 1311a2e

crates/chain/src/canonical_view.rs

github-project-automation bot added this to BDK Chain Sep 11, 2025

evanlinjin force-pushed the canonical-view branch 4 times, most recently from 7eb1084 to efb257f Compare September 11, 2025 12:21

evanlinjin marked this pull request as ready for review September 12, 2025 06:54

evanlinjin requested review from LagginTimes, ValuedMammal and oleonardolima September 12, 2025 06:55

evanlinjin self-assigned this Sep 12, 2025

evanlinjin moved this to Needs Review in BDK Chain Sep 12, 2025

evanlinjin added the api A breaking API change label Sep 12, 2025

evanlinjin added this to the Wallet 3.0.0 milestone Sep 12, 2025

oleonardolima reviewed Sep 15, 2025

View reviewed changes

evanlinjin and others added 8 commits September 17, 2025 23:46

feat(chain)!: Remove CanonicalTx

beb16a1

BREAKING: Remove `CanonicalTx` as it's no longer needed.

docs(chain): Improve CanonicalView documentation

8ad138d

Add comprehensive docs for CanonicalView module, structs, and methods. Fix all doctests to compile and pass with proper imports.

refactor(chain)!: Rename CanonicalViewTx to CanonicalTx

f444a8d

Also update submodule-level docs for `tx_graph`'s Canonicalization section.

docs(chain): Tighten CanonicalView documentation

40790d0

refactor(example): Reuse CanonicalView in filter iter example

3f9eec5

evanlinjin force-pushed the canonical-view branch from 809c153 to 3f9eec5 Compare September 17, 2025 23:54

ValuedMammal reviewed Sep 18, 2025

View reviewed changes

evanlinjin requested a review from ValuedMammal September 18, 2025 05:52

oleonardolima approved these changes Sep 18, 2025

View reviewed changes

This was referenced Sep 19, 2025

Update Balance immature category calculation to consider MTP-based maturity #2040

Open

feat(chain): Add extract_subgraph() and roots() methods to CanonicalView #2041

Open

oleonardolima mentioned this pull request Sep 23, 2025

refactor(chain,core)!: replace CanonicalIter with sans-IO CanonicalTask + ChainQuery trait #2038

Open

3 tasks

thunderbiscuit mentioned this pull request Sep 23, 2025

Return wallet events when applying updates bitcoindevkit/bdk_wallet#310

Merged

5 tasks

oleonardolima force-pushed the canonical-view branch from cb72f4a to 1311a2e Compare September 24, 2025 01:25

evanlinjin removed the request for review from LagginTimes September 24, 2025 04:53

evanlinjin commented Sep 25, 2025

View reviewed changes

ValuedMammal approved these changes Sep 25, 2025

View reviewed changes

oleonardolima approved these changes Sep 29, 2025

View reviewed changes

crates/chain/src/canonical_view.rs Show resolved Hide resolved

oleonardolima mentioned this pull request Sep 29, 2025

The CanonicalIter should return the TxNode's. #2051

Open

oleonardolima merged commit 00efcde into bitcoindevkit:master Sep 29, 2025
20 of 21 checks passed

github-project-automation bot moved this from Needs Review to Done in BDK Chain Sep 29, 2025

notmandatory modified the milestones: Wallet 3.0.0, Chain 0.24.0 Feb 1, 2026

ValuedMammal mentioned this pull request Feb 3, 2026

feat(wallet): add helper to compute balance with minimum confirmations bitcoindevkit/bdk_wallet#303

Closed

5 tasks

	mut trust_predicate: impl FnMut(&O, ScriptBuf) -> bool,
	mut trust_predicate: impl FnMut(&O, &FullTxOut<A>) -> bool,

Conversation

evanlinjin commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog notice

Checklists

All Submissions:

New Features:

Uh oh!

oleonardolima left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LagginTimes commented Sep 16, 2025

Uh oh!

ValuedMammal Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

evanlinjin Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

evanlinjin Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ValuedMammal Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

oleonardolima left a comment

Choose a reason for hiding this comment

Uh oh!

oleonardolima commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evanlinjin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ValuedMammal left a comment

Choose a reason for hiding this comment

Uh oh!

oleonardolima commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oleonardolima commented Sep 26, 2025

Uh oh!

evanlinjin commented Sep 26, 2025

Uh oh!

oleonardolima left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

evanlinjin commented Sep 11, 2025 •

edited

Loading

evanlinjin Sep 19, 2025 •

edited

Loading

oleonardolima commented Sep 24, 2025 •

edited

Loading

evanlinjin left a comment •

edited

Loading

oleonardolima commented Sep 26, 2025 •

edited

Loading