Skip to content

Conversation

@oleonardolima
Copy link
Contributor

Description

There's some annoying clippy warnings/errors that I'm only facing on the CI and not able to reproduce locally. I'm fixing those here.

Changelog notice

### Changed
- Update the string formatting in `example_cli`.

Checklists

All Submissions:

@oleonardolima oleonardolima added this to the Chain 0.24.0 milestone Sep 23, 2025
@oleonardolima oleonardolima self-assigned this Sep 23, 2025
@oleonardolima oleonardolima marked this pull request as ready for review September 23, 2025 00:17
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 62da6dc

@oleonardolima oleonardolima merged commit ee6637b into bitcoindevkit:master Sep 23, 2025
19 of 20 checks passed
@oleonardolima oleonardolima deleted the fix/clippy-warnings branch September 23, 2025 02:10
ValuedMammal added a commit that referenced this pull request Oct 9, 2025
…py fixes

c123a28 fix(electrum): clippy warnings (Leonardo Lima)
08e189f fix(example_cli): clippy warnings (Leonardo Lima)
6c43b46 fix(ci): update `webpki-roots` pinned version (Leonardo Lima)

Pull request description:

  backport #2058 and #2043 to `release/chain-0.23.x`

  ### Description

  ### Notes to the reviewers

  ### Changelog notice

  ### Checklists

  #### All Submissions:

  * [ ] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK c123a28
  notmandatory:
    ACK c123a28

Tree-SHA512: 74749c139e78f9e7ddb8dae655d73fb50938ff6eb7708bcb56f21bcc47faa9ddefa79b5c19251f5b95fc4bd351948caf9dcbb814d4629db8cb0a8b67f8083014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants