Skip to content

Move @expo/config-plugins to peer/dev dependencies#181

Closed
friederbluemle wants to merge 2 commits intobitdriftlabs:mainfrom
friederbluemle:mv-expo-dep
Closed

Move @expo/config-plugins to peer/dev dependencies#181
friederbluemle wants to merge 2 commits intobitdriftlabs:mainfrom
friederbluemle:mv-expo-dep

Conversation

@friederbluemle
Copy link
Copy Markdown
Contributor

Problem

@expo/config-plugins is currently a direct dependency, which means it gets installed for all users - including those with bare React Native apps who don't use Expo.

Solution

Follow the industry standard pattern (e.g. used by Sentry and React Native Firebase):

  1. Remove @expo/config-plugins from dependencies
  2. Add expo as an optional peer dependency

Why this works

  • @expo/config-plugins is a transitive dependency of expo
  • Expo users already have expo installed, so the plugin code can import from @expo/config-plugins
  • Non-Expo users won't have expo installed, but they also won't use the config plugin code at all
  • The plugin is only invoked during Expo's prebuild phase, which only runs in Expo projects
  • For local library development, add @expo/config-plugins to devDependencies, so that imports resolve

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 11, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@friederbluemle
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@friederbluemle
Copy link
Copy Markdown
Contributor Author

recheck

@FranAguilera
Copy link
Copy Markdown
Contributor

@friederbluemle apologies about the delay and thanks for you contribution!

This is a nice improvement though we are investigating why our integration tests keeps failing just on ci (same tests passes locally). We'll continue looking and provide an update very soon.

@friederbluemle
Copy link
Copy Markdown
Contributor Author

Sounds good, thank you!

add peer deps meta to prepare-release command

add devDependencies to prepare-release command
@jacksonhardaker
Copy link
Copy Markdown
Contributor

Sorry for the delay @friederbluemle. TLDR, the e2e test job is failing due to the fact that CI appears to be running within the context of your forked repo, which is missing necessary secrets. We'll look into a more permanent solution, but for now I've duplicated your PR in #193 so that we can get it merged.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants