Move @expo/config-plugins to peer/dev dependencies#181
Closed
friederbluemle wants to merge 2 commits intobitdriftlabs:mainfrom
Closed
Move @expo/config-plugins to peer/dev dependencies#181friederbluemle wants to merge 2 commits intobitdriftlabs:mainfrom
friederbluemle wants to merge 2 commits intobitdriftlabs:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
Contributor
|
@friederbluemle apologies about the delay and thanks for you contribution! This is a nice improvement though we are investigating why our integration tests keeps failing just on ci (same tests passes locally). We'll continue looking and provide an update very soon. |
Contributor
Author
|
Sounds good, thank you! |
add peer deps meta to prepare-release command add devDependencies to prepare-release command
2fcab44 to
992ee74
Compare
Contributor
|
Sorry for the delay @friederbluemle. TLDR, the e2e test job is failing due to the fact that CI appears to be running within the context of your forked repo, which is missing necessary secrets. We'll look into a more permanent solution, but for now I've duplicated your PR in #193 so that we can get it merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@expo/config-pluginsis currently a direct dependency, which means it gets installed for all users - including those with bare React Native apps who don't use Expo.Solution
Follow the industry standard pattern (e.g. used by Sentry and React Native Firebase):
Why this works
@expo/config-pluginstodevDependencies, so that imports resolve