Skip to content

Conversation

@sunkup
Copy link
Member

@sunkup sunkup commented Jun 11, 2025

Add LocalStorageException to synctools package which is meant to replace CalendarStorageException and ContactsStorageException.

@sunkup sunkup self-assigned this Jun 11, 2025
@sunkup sunkup added the refactoring Quality improvement of existing functions label Jun 11, 2025
@sunkup sunkup linked an issue Jun 11, 2025 that may be closed by this pull request
@sunkup sunkup requested review from ArnyminerZ and rfc2822 June 11, 2025 08:09
@sunkup sunkup marked this pull request as ready for review June 11, 2025 08:09
@rfc2822
Copy link
Member

rfc2822 commented Jun 11, 2025

Can we already replace the old *StorageExceptions? I think the only thing we have to pay attention to is when they're explicitly caught either in this lib or in DAVx5.

@sunkup
Copy link
Member Author

sunkup commented Jun 11, 2025

Can we already replace the old *StorageExceptions? I think the only thing we have to pay attention to is when they're explicitly caught either in this lib or in DAVx5.

Yes, there is one occurence in DAVx5 for the both

Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@rfc2822 rfc2822 merged commit c37ecc2 into main Jun 11, 2025
9 checks passed
@rfc2822 rfc2822 deleted the 12-unify-calendarstorageexception-and-contactsstorageexception branch June 11, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Quality improvement of existing functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify CalendarStorageException and ContactsStorageException

2 participants