Fix Feedbacks

[janikwitzig]

The console status is not kept properly. This probably comes from the prior deletion of a second OSC command with each command that is sent.

Sending the second command without an argument makes the console reply with the current status for that path, which is then used by the module to update the internal status.

Since the console returns the status after an OSC command, I think there should be a way of parsing this return value to something useful. The problem currently is that not all returned values come in the form that we would expect.

Closes #174

[justindube1987]

With this commit, after doing yarn install and yarn build, I'm not getting past the repeating "sending subscription command". Companion logs attached:

26.01.03 14:37:42 System: ** Starting Instance from "C:\Users\justi\Documents\m4lconnection\official\companion-module-behringer-wing\dist\index.js" ** 26.01.03 14:37:42 System: ** Process started ** 26.01.03 14:37:42 Console: Starting up module class: WingInstance 26.01.03 14:37:42 Module: Initializing 26.01.03 14:37:42 Console: Module-host accepted registration 26.01.03 14:37:42 Module: [Wing] Opening OSC connection from 0.0.0.0:0 to 192.168.1.110:2223 26.01.03 14:37:42 Module: [Wing] Setting subscription interval to 9000 ms 26.01.03 14:37:42 Module: [Wing] Sending subscription command 26.01.03 14:37:42 Module: [Wing] Started subscription for OSC updates 26.01.03 14:37:42 Module: [Wing] Setting up variables 26.01.03 14:37:42 Module: [Wing] Defined 5642 variables 26.01.03 14:37:42 Module: Updating variable definitions (5642 variables) 26.01.03 14:37:42 Module: Updating action definitions (96 actions) 26.01.03 14:37:42 Module: Updating feedback definitions (17 feedbacks) 26.01.03 14:37:42 Module: Status: connecting - waiting for response from console... 26.01.03 14:37:42 Module: [Wing] Detected console WING-PP-16011143 at 192.168.1.110 26.01.03 14:37:51 Module: [Wing] Sending subscription command 26.01.03 14:38:00 Module: [Wing] Sending subscription command

[janikwitzig]

Does Companion truly not connect, i.e. you cannot send commands to the Wing or does it simply not show the green checkmark?

[justindube1987]

Does Companion truly not connect, i.e. you cannot send commands to the Wing or does it simply not show the green checkmark?

I don't get the green checkmark. For reference, I am connected to the Wing currently using Wing Edit and am able to connect using other versions of the module.

[janikwitzig]

I think this has to do with a logic flaw in the connection handling. The checkmark, circle, etc. are only status indicators, and the actual status might be different.

I currently observe the exact same behavior, but once I send a command to the Wing it is executed and the green checkmark appears. Can you try that?

[janikwitzig]

I opened #177 that should address the status issue