Merged
Conversation
Merged
Contributor
|
Everything appears to be functional now on my end with this commit! |
Collaborator
Author
|
Great, thanks for testing! |
Contributor
|
@janikwitzig testing now and seeing 1. the call for all variables is almost instant (no throttle). and 2. the data received from the Wing starts to bog down and stops before all messages are received sometimes. Also sometimes, when changes are made on the Wing, there's a significant delay before 2026-01-04.15-08-00.mp4data is received by the module. Attempting to attach a video for example. |
Collaborator
Author
|
@justindube1987 thanks for letting me know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Companion module status logic seems to be flawed.
When a connection is initiated, the status is set to
InstanceStatus.Connectingwhen thereadyevent from osc is received. This could lead to the module actually having an established connection but not showing it to the user, which could be confusing.This PR addresses this by setting the status to
InstanceStatus.Connectingearlier in the process and then setting it toInstanceStatus.Okwhen the osc socket is ready.This PR should close #173 and solve an issue from #175