Remove error log for Intel CPU/XPU #1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
akx
reviewed
Feb 11, 2025
bitsandbytes/cextension.py
Outdated
| from bitsandbytes.backends.cpu_xpu_common import ipex_cpu, ipex_xpu | ||
|
|
||
| if ipex_cpu or ipex_xpu: | ||
| return None |
Contributor
There was a problem hiding this comment.
The type annotation for this function does not indicate it could ever return None.
Contributor
Author
There was a problem hiding this comment.
Sorry for I forgot to remove return None in this function. Now, it's okay.
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Contributor
Author
|
Hi @Titus-von-Koeller @matthewdouglas @akx . We are seeking to remove this error log, I know BNB is under refactoring, but this is emergent. Many Intel customers reported this issue. Can we temporarily fix the issue by this PR? Thanks! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
matthewdouglas
merged commit 54a2ad5
into
bitsandbytes-foundation:multi-backend-refactor
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intel CPU/XPU do not need compile any C++ file, so we can remove the error log.