Skip to content

Remove error log for Intel CPU/XPU #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 8, 2025
Merged

Remove error log for Intel CPU/XPU #1503

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cd6d479
fix intel cpu/xpu warning
jiqing-feng Feb 8, 2025
eadf0f3
fix error log
jiqing-feng Feb 8, 2025
65b65e6
Merge branch 'multi-backend-refactor' into multi
jiqing-feng Feb 11, 2025
b798376
fix lib
jiqing-feng Feb 11, 2025
540a717
rm return Nonr
jiqing-feng Feb 12, 2025
63dbf45
error log only without ipex
jiqing-feng Feb 12, 2025
f755070
Merge branch 'multi-backend-refactor' into multi
jiqing-feng Feb 12, 2025
ade64d0
fix import eerror
jiqing-feng Feb 20, 2025
30e33dc
fix format
jiqing-feng Feb 20, 2025
f6b581f
Merge branch 'multi-backend-refactor' into multi
jiqing-feng Mar 25, 2025
6358194
Merge branch 'multi-backend-refactor' into multi
jiqing-feng Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bitsandbytes/cextension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ def __init__(self, lib: ct.CDLL):


def get_native_library() -> BNBNativeLibrary:
from bitsandbytes.backends.cpu_xpu_common import ipex_cpu, ipex_xpu

if ipex_cpu or ipex_xpu:
return None
Copy link
Contributor

@akx akx Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type annotation for this function does not indicate it could ever return None.

Copy link
Contributor Author

@jiqing-feng jiqing-feng Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@akx akx Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was done?

Copy link
Contributor Author

@jiqing-feng jiqing-feng Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for I forgot to remove return None in this function. Now, it's okay.


binary_path = PACKAGE_DIR / f"libbitsandbytes_cpu{DYNAMIC_LIBRARY_SUFFIX}"
cuda_specs = get_cuda_specs()
if cuda_specs:
Expand Down
4 changes: 2 additions & 2 deletions docs/source/installation.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,10 +341,10 @@ pip install -e . # `-e` for "editable" install, when developing BNB (otherwise
</hfoption>
<hfoption id="Intel CPU + GPU">

#### Intel CPU
#### Intel CPU / XPU

> [!TIP]
> Intel CPU backend only supports building from source; for now, please follow the instructions below.
> Intel CPU / XPU backend only supports building from source; for now, please follow the instructions below.

Similar to the CUDA case, you can compile bitsandbytes from source for Linux and Windows systems.

Expand Down