Skip to content

fix build error: "no case matching constant switch condition" #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

fix build error: "no case matching constant switch condition" #1802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66f6b8c
fix switch error
yuguo68 Nov 13, 2025
77cc99f
Apply suggestion from @matthewdouglas
matthewdouglas Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions csrc/kernels.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,8 @@ __launch_bounds__(BLOCK_SIZE / NUM_VALS, 1) __global__ void kPreconditionOptimiz
s1_vals[j] = s1_vals[j] / (sqrtf(s2_vals[j]) + eps); // update
s1_vals[j] *= s1_vals[j]; // update l2 norm (update*update)
break;
case ADEMAMIX:
break;
}
}

Expand Down
2 changes: 2 additions & 0 deletions csrc/kernels.hip
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,8 @@ __global__ void kPreconditionOptimizer32bit2State(T* g, T* p,
s1_vals[j] = s1_vals[j]/(sqrtf(s2_vals[j])+eps); // update
s1_vals[j] *= s1_vals[j]; // update l2 norm (update*update)
break;
case ADEMAMIX:
break;
}
}

Expand Down