Skip to content

Conversation

@yuguo68
Copy link
Contributor

@yuguo68 yuguo68 commented Nov 13, 2025

hitting the following error when building on AMD gpu

Stderr:
bitsandbytes/0.47.0._git_c0dcdf2/csrc/kernels.hip:637:18: error: no case matching constant switch condition '6' [-Werror]
  637 |           switch(OPTIMIZER)
      |                  ^~~~~~~~~
bitsandbytes/0.47.0._git_c0dcdf2/csrc/kernels.hip:2947:1: note: in instantiation of function template specialization 'kPreconditionOptimizer32bit2State<float, 6, 4096, 8>' requested here
 2947 | MAKE_PreconditionOptimizer32bit2State(ADEMAMIX, float)
      | ^
bitsandbytes/0.47.0._git_c0dcdf2/csrc/kernels.hip:2939:26: note: expanded from macro 'MAKE_PreconditionOptimizer32bit2State'
 2939 | template __global__ void kPreconditionOptimizer32bit2State<gtype, oname, 4096, 8>(gtype* g, gtype* p,  \
      |                          ^
bitsandbytes/0.47.0._git_c0dcdf2/csrc/kernels.hip:637:18: error: no case matching constant switch condition '6' [-Werror]

Copy link
Member

@matthewdouglas matthewdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense with -Werror. LGTM, thanks!

@github-actions
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@matthewdouglas matthewdouglas added this to the v0.49.0 milestone Nov 13, 2025
@matthewdouglas matthewdouglas merged commit bcdc4de into bitsandbytes-foundation:main Nov 13, 2025
53 checks passed
@yuguo68
Copy link
Contributor Author

yuguo68 commented Nov 13, 2025

Makes sense with -Werror. LGTM, thanks!

thank you for the quick review and removing the whitespaces!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants